#1919 user prefs update sets display_name to None for auth.method local

v1.0.0
closed
sf-1 (616)
General
nobody
2015-08-20
2011-04-07
Anonymous
No

Originally created by: larryhoward

When display_name is not passed to update in controllers/auth.py and the auth.method is local, the user's display_name is set to the default parameter value None. And since display_name is not in User Preferences, this problem is unrecoverable via the UI.

Recommend adding display_name to User Preferences or guard in update.

Related

Tickets: #2176

Discussion

  • Rick Copeland - 2011-04-07
    • milestone: limbo --> backlog
     
  • Dave Brondsema

    Dave Brondsema - 2011-04-15
    • size: --> 1
    • milestone: backlog --> apr-21
     
  • Jenny Steele - 2011-04-15
    • status: open --> in-progress
    • assigned_to: Jenny Steele
     
  • Jenny Steele - 2011-04-18
    • status: in-progress --> code-review
    • assigned_to: Jenny Steele --> John Hoffmann
     
  • Jenny Steele - 2011-04-18

    To confirm fix on js/1919:

    1) Set auth.method = local in your ini file.
    2) Log in and go to user's prefs page (/auth/prefs/)
    3) Scroll down to display name, empty the field, and try to save the form.
    4) Error message will appear.
    5) Now put a name in the box, save the form, and make sure it updates as expected.

     
  • John Hoffman - 2011-04-19

    Looks good, merged.

     
  • John Hoffman - 2011-04-19
    • status: code-review --> closed
     
  • Dave Brondsema

    Dave Brondsema - 2011-04-19

    Larry,

    Thanks for reporting this - the fix is now available in our public repo on the 'dev' branch. Let us know if you have any trouble with it, or other feedback about Allura.

     
  • Anonymous - 2011-05-16

    Originally by: warjan

    I can't change "Display Name" on my https://sourceforge.net/auth/prefs/ prefrences page. After changing the "Display Name" field I see Error Display Name cannot be empty. I neither can change "Email format" combo value. Same error. Is this related?

     
  • Dave Brondsema

    Dave Brondsema - 2011-05-27

    warjan, I've filed this as a new ticket [#2176]

     

    Related

    Tickets: #2176


Log in to post a comment.