--- old+++ new@@ -1,3 +1 @@-These aren't part of core Allura for licensing and demonstration reasons, but would be good to keep maintaining them.--TracWikiImporter doesn't have much test coverage, and doesn't get used much at all. Main Allura codebase has a test that uses it: forgeimporters.trac.tests.functional.test_trac:TestTracImportController+These aren't part of core Allura for licensing reasons, but would be good to keep maintaining them.
status: open --> review
assigned_to: Dave Brondsema
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
nosetests must be run with --nocapture on py3, due to nosetests replacing sys.stdout with a simple object that doesn't have .buffer attribute that Mercurial expects
allura branch has some misc other py3 fixes included
Last edit: Dave Brondsema 2020-11-05
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Also I ended up using pip install -e . instead of python setup.py develop in the forgehg dir. Its the newer pip-friendly equivalent, not sure if its always needed but I had some issues with entry points not being found with the setup.py version
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Cool 😄 I think with this now Allura is pretty much python3 ready, but hasn't gotten a lot of real-world testing yet. So let us know if you have any issues.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Diff:
allura,forgehg:db/8379
nosetestsmust be run with--nocaptureon py3, due to nosetests replacingsys.stdoutwith a simple object that doesn't have.bufferattribute that Mercurial expectsallura branch has some misc other py3 fixes included
Last edit: Dave Brondsema 2020-11-05
Also I ended up using
pip install -e .instead ofpython setup.py developin the forgehg dir. Its the newer pip-friendly equivalent, not sure if its always needed but I had some issues with entry points not being found with the setup.py versionThanks Dave!
This was an important upgrade info.
As I am planning a smoke test with python 3 for my site, I will need this
for sure.
Cool 😄 I think with this now Allura is pretty much python3 ready, but hasn't gotten a lot of real-world testing yet. So let us know if you have any issues.
Looks good to me!