Guillermo Cruz wants to merge 3 commits from /u/guillermocruz/allura/ to master, 2021-04-16
Set a limit for phone verification attempts
Commit | Date | |
---|---|---|
[e04d6b]
(gc/phone-rate-limit)
by
Guillermo Cruz
removed unnecessary config in tests, set a default value in case phone.attempts_limit is not in config file and converted setting to integer |
2021-04-16 19:19:16 | Tree |
2021-04-15 21:24:56 | Tree | |
2021-04-15 21:06:48 | Tree |
attempt_limit = config.get('phone.attempts_limit', 5)
so anyone who doesn't have it set yet will have it work ok? Otherwise they'll get errors. Also I think then it won't have to be specified in all the different phone tests (just the new one)phone.attempts_limit = 1
in the .ini file to encounter the error real soon, but it didn't happen. I think because the config file is all text strings. So you need to convert the limit toint
before comparing to the user count. It'd be good to have the test reflect this too like'phone.attempts_limit': '5'
(string)