#8040 Upgrade SimpleMDE and contribute our toggleCodeBlock

v1.5.0
closed
General
Heith Seewald
2016-04-28
2016-01-06
No

Now that [#7987] has us on a standard rendering of code blocks, we should contribute our toggleCodeBlock functionality back to SimpleMDE. It needs a bit of cleanup with extra \n insertion no longer needed.

We'll need to upgrade to the latest version, which might require some changes. And once our contribution is accepted, upgrade to that release too.

Related

Tickets: #7987

Discussion

  • Dave Brondsema

    Dave Brondsema - 2016-01-19
    • status: open --> in-progress
    • assigned_to: Dave Brondsema
     
  • Dave Brondsema

    Dave Brondsema - 2016-01-25
    • labels: --> sf-current, sf-4
     
  • Dave Brondsema

    Dave Brondsema - 2016-01-26
    • status: in-progress --> review
     
  • Dave Brondsema

    Dave Brondsema - 2016-01-26

    db/8040

     
  • Heith Seewald

    Heith Seewald - 2016-03-11

    Looks good with the exception of the "insert table" button.

    Clicking it causes: Uncaught ReferenceError: _replaceSelection is not defined

     
  • Heith Seewald

    Heith Seewald - 2016-03-11
    • status: review --> in-progress
     
  • Dave Brondsema

    Dave Brondsema - 2016-04-27
    • status: in-progress --> review
    • Reviewer: Heith Seewald
     
  • Dave Brondsema

    Dave Brondsema - 2016-04-27

    Fixed insert table button.

     
  • Heith Seewald

    Heith Seewald - 2016-04-28
    • status: review --> closed
     
  • Heith Seewald

    Heith Seewald - 2016-04-28

    Looks good. Merged/closed

     
  • Dave Brondsema

    Dave Brondsema - 2016-08-22
    • Milestone: unreleased --> v1.5.0
     

Log in to post a comment.