Recent changes to 8618: fix git thread-safety issues

#8618 fix git thread-safety issues

Dave Brondsema — Tue, 25 Aug 2026 17:30:56 -0000

Description has changed:

Diff:

--- old
+++ new
@@ -1,7 +1,7 @@
 Got this when we were taking a lots of simultaneous requests.  Weird error showing template code from a repo, where a SHA was expected. 

 ```

-  &#39;/var/local/allura/Allura/allura/controllers/repository.py&#39;, line 906 in index
+   File &#39;/var/local/allura/Allura/allura/controllers/repository.py&#39;, line 906 in index
      return self.raw()
    File &#39;/var/local/allura/Allura/allura/controllers/repository.py&#39;, line 942 in raw
      return iter(self._blob)
@@ -23,4 +23,5 @@
      return self._parse_object_header(cmd.stdout.readline())
    File &#39;/var/local/env-allura/lib/python3.11/site-packages/git/cmd.py&#39;, line 1814 in _parse_object_header
      raise ValueError(&#34;SHA %s could not be resolved, git returned: %r&#34; % (tokens[0], header_line.strip()))
-   ValueError: SHA b&#39;{%&#39; could not be resolved, git returned: b&#39;{% extends g.theme.master %}&#39;```
+   ValueError: SHA b&#39;{%&#39; could not be resolved, git returned: b&#39;{% extends g.theme.master %}&#39;
+```

fix git thread-safety issues

Dave Brondsema — Tue, 25 Aug 2026 17:30:18 -0000

Got this when we were taking a lots of simultaneous requests. Weird error showing template code from a repo, where a SHA was expected.

'/var/local/allura/Allura/allura/controllers/repository.py', line 906 in index return self.raw() File '/var/local/allura/Allura/allura/controllers/repository.py', line 942 in raw return iter(self._blob) File '/var/local/allura/Allura/allura/model/repository.py', line 1615 in __iter__ return iter(self.open()) File '/var/local/allura/Allura/allura/model/repository.py', line 1612 in open return self.repo.open_blob(self) File '/var/local/allura/Allura/allura/model/repository.py', line 487 in open_blob return self._impl.open_blob(blob) File '/var/local/allura/ForgeGit/forgegit/model/git_repo.py', line 500 in open_blob self._object(blob._id).data_stream) File '/var/local/env-allura/lib/python3.11/site-packages/git/objects/base.py', line 201 in data_stream return self.repo.odb.stream(self.binsha) File '/var/local/env-allura/lib/python3.11/site-packages/git/db.py', line 50 in stream hexsha, typename, size, stream = self._git.stream_object_data(bin_to_hex(binsha)) File '/var/local/env-allura/lib/python3.11/site-packages/git/cmd.py', line 1896 in stream_object_data hexsha, typename, size = self.__get_object_header(cmd, ref) File '/var/local/env-allura/lib/python3.11/site-packages/git/cmd.py', line 1853 in __get_object_header return self._parse_object_header(cmd.stdout.readline()) File '/var/local/env-allura/lib/python3.11/site-packages/git/cmd.py', line 1814 in _parse_object_header raise ValueError("SHA %s could not be resolved, git returned: %r" % (tokens[0], header_line.strip())) ValueError: SHA b'{%' could not be resolved, git returned: b'{% extends g.theme.master %}'

fix git thread-safety issues

Dave Brondsema — Tue, 25 Aug 2026 17:30:18 -0000

Ticket 8618 has been modified: fix git thread-safety issues
Edited By: Dave Brondsema (brondsem)
Description updated:
--- description-old

+++ description-new

@@ -1,7 +1,7 @@

Got this when we were taking a lots of simultaneous requests. Weird error showing template code from a repo, where a SHA was expected.

```

'/var/local/allura/Allura/allura/controllers/repository.py', line 906 in index
File '/var/local/allura/Allura/allura/controllers/repository.py', line 906 in index
return self.raw()
File '/var/local/allura/Allura/allura/controllers/repository.py', line 942 in raw
return iter(self._blob)
@@ -23,4 +23,5 @@

return self._parse_object_header(cmd.stdout.readline())
File '/var/local/env-allura/lib/python3.11/site-packages/git/cmd.py', line 1814 in _parse_object_header
raise ValueError("SHA %s could not be resolved, git returned: %r" % (tokens[0], header_line.strip()))
ValueError: SHA b'{%' could not be resolved, git returned: b'{% extends g.theme.master %}'```
ValueError: SHA b'{%' could not be resolved, git returned: b'{% extends g.theme.master %}'
+```