Ticket search results

Phone validation interfering with project import

Dave Brondsema — Fri, 04 Sep 2015 18:28:15 -0000

~~~~ 15:18:01,597 ERROR [forgeimporters.base] error registering project: foobar Traceback (most recent call last): File "/var/local/allura/ForgeImporters/forgeimporters/base.py", line 292, in process project_name=kw['project_name']) File "/var/local/allura/Allura/allura/model/neighborhood.py", line 129, in register_project self, shortname, project_name, user or getattr(c, 'user', None), user_project, private_project, apps) File "/var/local/forge-classic/ForgeSF/forgesf/sf_providers.py", line 426, in register_project self.validate_project(neighborhood, shortname, project_name, user, user_project, private_project) File "/var/local/allura/Allura/allura/lib/plugin.py", line 816, in validate_project raise forge_exc.ProjectPhoneVerificationError() ProjectPhoneVerificationError ~~~~

Option to force phone validation language NEEDS INI

Dave Brondsema — Mon, 24 Aug 2015 14:28:59 -0000

This should be a .ini option. https://docs.nexmo.com/index.php/verify/verify `lg` param

clean_phone_number function is too eager to prepend 1-

Dave Brondsema — Mon, 24 Aug 2015 14:29:22 -0000

`clean_phone_number` will prepend 1- to any 10-digit number, in an attempt to help fix a US number that is missing the international prefix. However, there are valid 10-digit numbers that aren't US numbers, they are complete numbers including prefix for their own country. One idea to make it better would be to not do the "1-prepend" to a number if it starts with "+" already (since that indicates a country code is included). Another option is to not do the "1-prepend" at all, and when the service provider comes back with an error, then we suggest to the user that they might need to prepend "1-" if they are entering a US number.

Need to set focus when phone validation overlay appears

Dave Brondsema — Mon, 24 Aug 2015 14:29:28 -0000

When the phone validation overlay is enabled and shows up, we should set focus on **its** input field. Currently the focus stays on the project name field, so your typing goes into that field which is not what you want.

Better messaging for phone validation

Dave Brondsema — Thu, 20 Aug 2015 22:06:09 -0000

Some error messages from Nexmo are not good to show to the end-user. Example: "The Nexmo platform was unable to process this message for the following reason: Request 'a98f5e449f40462bb8d3bd48f41d867e' was not found or it has been verified already." Some are ok like "The code provided does not match the expected value" and "A wrong code was provided too many times. Workflow terminated" https://docs.nexmo.com/index.php/verify/search#verify_return_code has a list of possible return statuses. I think we should pass through to the user only numbers 3 10 15 16 17. The rest should show a generic error message to the user. We should show a couple example phone numbers like 1-311-555-2368 and +61 8 5550 1757 (both fake numbers that Nexmo won't accept) so that people know what kind of format they should put in. Show a better indication of status after submitting phone number. Instead of changing to just "Enter PIN", show "A PIN is being sent to your phone. If you are unable to receive SMS, you will get a voice call with the number
Enter your PIN:" It should be possible to have site-specific text added to the main paragraph either through template override or a bit of html as a config option. E.g. `Problems with verification? Get Support`

Clean up phone numbers before using them

Dave Brondsema — Thu, 20 Aug 2015 22:06:09 -0000

Rather than cleaning up phone numbers just for hashing, we should strip all non-numeric numbers earlier in the process. The nexmo provider requires all-numeric numbers: https://docs.nexmo.com/index.php/verify/verify Also to assist US phone owners (since we're not used to international phone formats), if number is 10 digits, prepend a '1' automatically.