Ticket search results

API support for attachments in export

Dave Brondsema — Mon, 25 Jan 2016 17:09:58 -0000

* after [#8051], update API to support the new attachments param * update API docs * republish API docs

API for current site notification

Dave Brondsema — Wed, 27 Jan 2016 17:43:01 -0000

Expose the current site notification (i.e. `ThemeProvider.get_site_notification` logic) as an API. The `request.cookies` might be able to stay as it is, but likely should support those values being passed in as regular API params. The `response.set_cookie` probably should be returned as response values. Make sure the RAML api docs are updated.

Better handing of tmp dirs during merge

Dave Brondsema — Wed, 27 Jan 2016 20:43:32 -0000

Doing a one-click merge of a very large repo can potentially cause problems if the working dir is bigger than the tmp dir mount supports. * `def merge` can use a try/finally so that `shutil.rmtree` always runs even if the clone fails (e.g. out of disk space) * see if its possible to a shared clone (see also `_shared_clone`) so the object files don't have to get copied, reducing disk usage and execution time. It'd be nice if we could set a max size limit and check that in `can_merge` or `merge_allowed` but it doesn't seem to be a way to check the size of a working copy ahead of time. There is `git count-objects -vH` but that's just the repo size, not the working copy.

Change jslint to use an npm tool instead of java

Dave Brondsema — Mon, 25 Jan 2016 15:34:04 -0000

We should switch our jslint tests to use npm-based jslint/jshint tool instead of java. Or eslint if it works. It will also let us remove the dependency on `default-jre-headless` which currently cases latest docker to hang with this: Setting up ca-certificates-java (20130815ubuntu1) ... Which is issue https://github.com/docker/docker/issues/18180

Support mongo 3.x

Dave Brondsema — Mon, 25 Jan 2016 15:34:10 -0000

`paster ensure_index` and `paster setup-app` (which calls the ensure index code) fail with this exception. I think pretty much everything else should work since pymongo/Ming were upgraded to more recent versions in [bae38a] ~~~~ 16:11:11,573 INFO [allura.command] Updating indexes for main DB Traceback (most recent call last): File "/allura-data/virtualenv/bin/paster", line 9, in load_entry_point('PasteScript==1.7.4.2', 'console_scripts', 'paster')() File "/allura-data/virtualenv/local/lib/python2.7/site-packages/paste/script/command.py", line 104, in run invoke(command, command_name, options, args[1:]) File "/allura-data/virtualenv/local/lib/python2.7/site-packages/paste/script/command.py", line 143, in invoke exit_code = runner.run(args) File "/allura-data/virtualenv/local/lib/python2.7/site-packages/paste/script/command.py", line 238, in run result = self.command() File "/allura/Allura/allura/command/show_models.py", line 238, in command self._update_indexes(db[name], indexes) File "/allura/Allura/allura/command/show_models.py", line 260, in _update_indexes for iname, fields in collection.index_information().iteritems(): File "/allura-data/virtualenv/local/lib/python2.7/site-packages/pymongo/collection.py", line 1278, in index_information read_preference=ReadPreference.PRIMARY) File "/allura-data/virtualenv/local/lib/python2.7/site-packages/pymongo/database.py", line 345, in _command msg, allowable_errors) File "/allura-data/virtualenv/local/lib/python2.7/site-packages/pymongo/helpers.py", line 182, in _check_command_response raise OperationFailure(msg % errmsg, code, response) pymongo.errors.OperationFailure: command SON([('listIndexes', u'repo_ci'), ('cursor', {})]) on namespace allura.$cmd failed: no collection ~~~~

Fire event for any menu changes

Dave Brondsema — Mon, 11 Jan 2016 15:27:01 -0000

It would be useful for custom code integrations to know when a project menu has changed. So we should fire an event for that after tool installation, reordering, renaming, removal, or grouping threshold changes.

create-allura-sitemap.py broken

Dave Brondsema — Mon, 11 Jan 2016 15:26:56 -0000

`create-allura-sitemap.py` is erroring out with messages like this. I would guess due to [849433] Error creating sitemap for project 'test': 'EmptyClass' object has no attribute 'app' ... We should have tests for this too.

Use virtualenv inside docker

Dave Brondsema — Mon, 14 Dec 2015 16:10:45 -0000

Fix licensing of several files

Dave Brondsema — Mon, 30 Nov 2015 17:31:21 -0000

* Allura/allura/public/nf/js/pb.transformie.min.js * MIT license * Allura/allura/lib/widgets/resources/css/jquery.tagsinput.css * corresponding JS is MIT * Allura/allura/lib/widgets/resources/css/colorPicker.css * corresponding JS is MIT * Allura/allura/lib/widgets/resources/css/jqfontselector.css * corresponding JS is MIT * Allura/allura/public/nf/css/forge/hilite.css * from commit 86903da02f87a2aba44c33ab5a12bbe19f638c7f * similar looking stuff here, not sure of actual source: * https://github.com/modocache/modocachejp/blob/master/modocachejp/static/less/codehilite.less * https://gist.github.com/theodox/4fefeb539f1d8ec341b0 * several Makefile, make.bat for sphinx * BSD

Use Allura icon in favicon, footer, etc

Dave Brondsema — Mon, 25 Jan 2016 16:40:52 -0000

We should use the Allura icon in more places like the favicon (existing favicon.ico file is a gzipped turbegears logo, and isn't referenced) and in the footer by our name. Can copy from sf.net styling of that footer spot. Maybe show the logo on the homepage or a default sitewide logo too?

Activitystream needs ming config option NEEDS INI

Dave Brondsema — Mon, 30 Nov 2015 15:35:20 -0000

Allura uses the Activitystreams library and choses to use its Ming backend (specified in `Allura/setup.py`). Ming's `auto_ensure_indexes` setting defaults to true, but we should have a way to specify that as false for Activitystream. Ideally we'd be able to pass through any additional params, just like the regular ming configuration that Allura uses for its own allura & project-data connections.

Bug: removed upsert() method needed by TracWikiImporter

Dave Brondsema — Mon, 16 Nov 2015 16:09:46 -0000

We removed upsert() in [f33baf] but it is actually used. We should bring it back with a `user` param, or update TracWikiImporter to not need it. Traceback (most recent call last): File "/var/local/allura/ForgeImporters/forgeimporters/base.py", line 131, in import_tool mount_point=mount_point, mount_label=mount_label, **kw) File "/var/local/env-allura/lib/python2.7/site-packages/TracWikiImporter-0.4.2-py2.7.egg/tracwikiimporter/importer.py", line 94, in import_tool options.token = self.get_token(user) File "/var/local/env-allura/lib/python2.7/site-packages/TracWikiImporter-0.4.2-py2.7.egg/tracwikiimporter/importer.py", line 116, in get_token consumer_token = OAuthConsumerToken.upsert(self.classname) AttributeError: type object 'OAuthConsumerToken' has no attribute 'upsert'

Served SVG images can execute JS

Dave Brondsema — Mon, 02 Nov 2015 15:09:01 -0000

Since the SVG mime type (`image/svg+xml`) starts with `image/`, the `AttachmentController` lets it be displayed in the browser rather than download. However, SVGs can contain javascript and other insecure components. https://www.hackinparis.com/slides/hip2k11/09-TheForbiddenImage.pdf https://www.w3.org/wiki/SVG_Security

Markdown editor does not load when url hash contains slashes

Igor Bondarenko — Mon, 11 Jan 2016 15:26:38 -0000

Compare https://forge-allura.apache.org/p/allura/tickets/7924/#d1d2/ed24/f3ed and https://forge-allura.apache.org/p/allura/tickets/7924/#d1d2 for example In the first case markdown editor does not load and console has the following errors: ~~~~ Uncaught Error: Syntax error, unrecognized expression: #d1d2\/ed24/f3ed.title-pane (index):6200 Uncaught TypeError: $(...).tagsInput is not a function (index):6334 Uncaught TypeError: Cannot read property 'CodeMirror' of undefined ~~~~ in the second case editor is loading just fine Chrome Version 46.0.2490.71 (64-bit), Ubuntu

Bugs in attachments to comments

Dave Brondsema — Mon, 11 Jan 2016 15:26:34 -0000

Editing a comment to modify its attachments has some bugs, compared to what you can do for top-level artifact attachments. * no way to delete an attachment * uploading with the same name duplicates the file, rather than replace it (see [#4350] which could be considered a feature)

Adding attachment to wiki loses your text changes

Dave Brondsema — Mon, 11 Jan 2016 15:26:30 -0000

When editing a wiki page and adding or removing an attachment, any changes you may have made to the wiki text get lost. I'd suggest we make the add & delete attachments into ajax calls. (Another option would be submit the wiki text form too and controller would handle both types of changes at once). Ajax would be a nice direction towards someday allowing drag/drop of images into a markdown editor and auto-attach and insert `[[img src=...]]` for you.

Fix comments split across two threads, not all comments showing

Dave Brondsema — Mon, 05 Oct 2015 13:59:58 -0000

Google Code ticket imports can produce multiple "thread" objects with the same ref_id (pointer to a ticket). This means when viewing a ticket you get one of the comment threads, but you wont see the other comment thread associated with it. Back in [#4506] we wrote a script to fix this (was committed internal to SF at the time). We should move this script to Allura, or even better make the `get_discussion_thread` code handle this situation and automatically clean it up. No manually running scripts needed, and not critical to fix the Google Code import logic then.

Option to limit phone validation usage NEEDS ENSURE_INDEX

Dave Brondsema — Mon, 19 Oct 2015 13:54:50 -0000

It would be useful to have an option to limit phone validation to once per number (aka hash).

Wiki not imported properly from Google Code

John Barrett — Mon, 21 Sep 2015 14:06:09 -0000

https://sourceforge.net/p/forge/site-support/11216/ ---- Details from Support Ticket: ---- Hi, I have imported following project from google code. https://sourceforge.net/p/openwonderland/ The code imported successfully but the wiki page didn't look same as on the google code. https://sourceforge.net/p/openwonderland/wiki/OpenWonderland https://code.google.com/p/openwonderland/wiki/OpenWonderland Is it not imported properly?

Fix layout at bottom of subscriptions page

Dave Brondsema — Mon, 19 Oct 2015 13:54:46 -0000

`/auth/subscriptions` has a bad layout under the table. It'd be better to have "Email Format" and the dropdown adjacent to each other on the same line. And then align the "Save" button to the far right, also on the same line. A few other relatively easy cleanup tasks would be: * remove Topic, Type, and Frequency columns, since they aren't used * rename App to Tool * provide a way for apps to indicate they don't have any notifications (search, admin, activity, etc) and skip the rows for those types of apps

Fix pep8 and pyflakes violations

Dave Brondsema — Tue, 06 Oct 2015 10:35:25 -0000

At this time, we have 502 pep8 violations (at line length 119) and 346 pyflakes violations. Would be good to clean those up some.

Activity page fixes

Dave Brondsema — Mon, 14 Dec 2015 16:10:51 -0000

* need `@with_trailing_slash` for activity tool, otherwise things don't load right and you can't "follow" * it's not clear what following does. A few simple things to make the unified activity timeline page /u//activity easier to understand would help that. * We should add more links to that page E.g. from every activity page, from your profile or settings * And adjust the title of that page so its clear

JSX support

Dave Brondsema — Mon, 05 Oct 2015 13:59:42 -0000

We may need JSX support for [#7920] If so, we'll need to configure things like: * JSX compiling for development (with minimal dependencies added) * step-by-step instructions * Docker setup * script or something to run it for final "production-ready" output * run that script during `asf-release.sh` so that our releases don't require JSX tools to be installed

Incorrect Content-Type on first CSS requests, causing CSS not to be used

Dave Brondsema — Mon, 05 Oct 2015 14:07:47 -0000

I can't pull up an example right now unfortunately since it's only occasional. I think the URLs are the ones with `_ew_` in the path. And then if the response gets cached, then subsequent page loads still don't work either. [#7028] was for the same issue, so see that for additional details. That ticket just resulted in a workaround, but its not great (especially if it gets cached). This ticket is for a real fix.

test_merge_request_detail_view fails (intermittent)

Igor Bondarenko — Fri, 04 Sep 2015 18:28:08 -0000

~~~~~ ====================================================================== ERROR: forgegit.tests.functional.test_controllers.TestFork.test_merge_request_detail_view ---------------------------------------------------------------------- Traceback (most recent call last): File "/var/tmp/buildenv/2fa433a593c4e35609aa31e4291198025daf5171/lib/python2.7/site-packages/nose/case.py", line 197, in runTest self.test(*self.arg) File "/home/deploy/buildbot/slave3/full/build/ForgeGit/forgegit/tests/functional/test_controllers.py", line 633, in test_merge_request_detail_view c_id = self.forked_repo.get_heads()[0]['object_id'] File "/home/deploy/buildbot/slave3/full/build/Allura/allura/model/repository.py", line 484, in get_heads return self._impl.heads File "/var/tmp/buildenv/2fa433a593c4e35609aa31e4291198025daf5171/lib/python2.7/site-packages/ming/utils.py", line 18, in __get__ result = obj.__dict__[self.__name__] = self._func(obj) File "/home/deploy/buildbot/slave3/full/build/ForgeGit/forgegit/model/git_repo.py", line 595, in heads return self._get_refs('heads') File "/home/deploy/buildbot/slave3/full/build/ForgeGit/forgegit/model/git_repo.py", line 574, in _get_refs session(self._repo).flush(self._repo) AttributeError: 'NoneType' object has no attribute 'flush' -------------------- >> begin captured stdout << --------------------- Running setup_app() from allura.websetup http://localhost/p/test2/code/do_request_merge ==> 302 ==> http://localhost/p/test/src-git/merge-requests/1/ --------------------- >> end captured stdout << ---------------------- ~~~~~