Ticket search results

Tests create trove categories unnecessarily

Dave Brondsema — Thu, 20 Aug 2015 22:07:00 -0000

`wipe_database` creates all the trove categories, which is unnecessary in many cases. And in the case of some of the ForgeTracker unit/model tests which call `wipe_database`, the plethora of event tasks generated for the trove category changes take a very long time to process.

Test speedup by reducing user-app installation

Dave Brondsema — Thu, 20 Aug 2015 22:07:55 -0000

This gains a 30-40% speedup, based on initial test tests. I haven't tested everything, so some tests may need some user apps available -- and if not, we need to add tests that cover the user apps. Also, of course, we want to make it some sort of test config option, so that in real usage the user apps are installed. ~~~~ diff --git a/Allura/allura/model/project.py b/Allura/allura/model/project.py index 57e43d6..2cf2994 100644 --- a/Allura/allura/model/project.py +++ b/Allura/allura/model/project.py @@ -574,10 +574,7 @@ def configure_project( if users is None: users = [ c.user ] if apps is None: if is_user_project: - apps = [('Wiki', 'wiki', 'Wiki'), - ('profile', 'profile', 'Profile'), - ('admin', 'admin', 'Admin'), - ('search', 'search', 'Search')] + apps = [] else: apps = [('admin', 'admin', 'Admin'), ('search', 'search', 'Search')] diff --git a/Allura/allura/model/auth.py b/Allura/allura/model/auth.py index e66e469..e985e17 100644 --- a/Allura/allura/model/auth.py +++ b/Allura/allura/model/auth.py @@ -402,11 +402,12 @@ def register(cls, doc, make_project=True): p._extra_tool_status = ['user'] # add user project informative text to home home_app = p.app_instance('wiki') - home_page = WM.Page.query.get(app_config_id=home_app.config._id) - home_page.text = ("This is the personal project of %s." - " This project is created automatically during user registration" - " as an easy place to store personal data that doesn't need its own" - " project such as cloned repositories.") % user.display_name + if home_app: + home_page = WM.Page.query.get(app_config_id=home_app.config._id) + home_page.text = ("This is the personal project of %s." + " This project is created automatically during user registration" + " as an easy place to store personal data that doesn't need its own" + " project such as cloned repositories.") % user.display_name return user def private_project(self): ~~~~

Improve html5 validation performance

Paul Sokolovsky — Wed, 23 Mar 2011 14:41:38 -0000

Rick reported that adding online html5 validation increased testsuite runtime from 15 to 40 mins. There need to be more fine-grained control over which validations are to be run. Also, it would be nice to find alternative to online html5 validation.

Fix validation errors across all apps

Paul Sokolovsky — Thu, 20 Aug 2015 22:07:57 -0000

Now that #1233 is done and html5 theme fixes are backported, fix remaining validation errors across all apps, to be prepared to enable validation failures for tests.

Achieve 90% test coverage on Allura project

Rick Copeland — Thu, 20 Aug 2015 22:07:55 -0000

Cleanup Allura's BaseController

Paul Sokolovsky — Thu, 20 Aug 2015 22:07:56 -0000

From https://engr.geek.net/hudson/job/allura/414/testReport/junit/alluratest/test_syntax/test_pyflakes/ : pyflakes failure -------------------- >> begin captured stdout << --------------------- Allura/allura/lib/base.py:47: undefined name 'OEmbedController' Allura/allura/lib/base.py:50: undefined name 'HostNeighborhoodController' That's BaseController referring to its subclasses.

Factor out test support code to separate package

Paul Sokolovsky — Thu, 20 Aug 2015 22:07:53 -0000

From mail: 2. So, I'd like to propose to separate test support functionality into own top-level package, and consolidate all test related functionality under it (e.g., move twill-tests in there). 3. Do this in such way as to look forward to separate this into package reusable across projects (for example, current validation tests in allura is concurrent fork of sfpy's tests).