Recent changes to Contributing Code

Contributing Code modified by Shalitha Suranga

Shalitha Suranga — Fri, 26 Oct 2018 04:47:13 -0000

--- v4
+++ v5
@@ -1,6 +1,6 @@
 #Contributing Code

-If you're new to Allura development, be sure to check out the [Contributing Guide](https://forge-allura.apache.org/docs/contributing.html) in the official docs before getting started.
+If you're new to Allura development, be sure to check out the [Contributing Guide](https://forge-allura.apache.org/docs/development/contributing.html) in the official docs before getting started.

 Develop and test your patches locally and then push your changes up to your fork of Allura, and from there send us a merge request.

Contributing Code modified by Dave Brondsema

Dave Brondsema — Wed, 02 Sep 2015 14:42:42 -0000

--- v3
+++ v4
@@ -6,7 +6,7 @@

 Things your commits must have/do:

-* follow PEP-8 (<http: www.python.org="" dev="" peps="" pep-0008=""/>) coding guidelines
+* follow [PEP-8](http://www.python.org/dev/peps/pep-0008/) coding guidelines (except the 79-char line length.  Going up to 100, sometimes even 119 is ok)
 * contain appropriate tests to be added to the automated tests
 * pass existing tests (and/or fix existing tests that need to change)
 * be divided into an appropriate number of commits, one per reasonable "chunk" of functionality

Contributing Code modified by Dave Brondsema

Dave Brondsema — Fri, 28 Mar 2014 14:23:54 -0000

--- v2
+++ v3
@@ -1,23 +1,19 @@
 #Contributing Code

-If you're new to Allura development, be sure to check out the [Contributing Guide](http://allura.sourceforge.net/docs/contributing.html) in the official docs before getting started.
+If you're new to Allura development, be sure to check out the [Contributing Guide](https://forge-allura.apache.org/docs/contributing.html) in the official docs before getting started.

-Develop and test your patches locally and then push your changes up to your 'forked' repo on SourceForge, and from there send us a merge request.
+Develop and test your patches locally and then push your changes up to your fork of Allura, and from there send us a merge request.

 Things your commits must have/do:

 * follow PEP-8 () coding guidelines
-
-* contain appropriate tests to be added to the automated testing machinery
-
+* contain appropriate tests to be added to the automated tests
 * pass existing tests (and/or fix existing tests that need to change)
-
 * be divided into an appropriate number of commits, one per reasonable "chunk" of functionality

-Things your patch will have before it can be merged into branch 'dev' or 'master':
+Things your patch will have before it can be merged into the 'master' branch:

 * Discussion either on the mailing list or in the merge request, where you submitted it
-
 * Code-review (possibly many times as you re-work your patches in response to discussion)

 Very small patches might not need much discussion.

Contributing Code modified by Tim Van Steenburgh

Tim Van Steenburgh — Fri, 03 Jan 2014 17:38:12 -0000

--- v1
+++ v2
@@ -1,4 +1,6 @@
 #Contributing Code
+
+If you're new to Allura development, be sure to check out the [Contributing Guide](http://allura.sourceforge.net/docs/contributing.html) in the official docs before getting started.

 Develop and test your patches locally and then push your changes up to your 'forked' repo on SourceForge, and from there send us a merge request.

Contributing Code modified by Dave Brondsema

Dave Brondsema — Fri, 13 Sep 2013 15:44:24 -0000

Contributing Code

Develop and test your patches locally and then push your changes up to your 'forked' repo on SourceForge, and from there send us a merge request.

Things your commits must have/do:

follow PEP-8 (http://www.python.org/dev/peps/pep-0008/) coding guidelines
contain appropriate tests to be added to the automated testing machinery
pass existing tests (and/or fix existing tests that need to change)
be divided into an appropriate number of commits, one per reasonable "chunk" of functionality

Things your patch will have before it can be merged into branch 'dev' or 'master':

Discussion either on the mailing list or in the merge request, where you submitted it
Code-review (possibly many times as you re-work your patches in response to discussion)

Very small patches might not need much discussion.