Git Merge Request #133: [#8090] Show merge requests in sidebar, even if there are none for forkable repos (merged)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Rohan Verma wants to merge 2 commits from /u/rhnvrm/allura/ to master, 2016-06-23

I added a check for the repo to be forkable because the Merge Requests button should not be visible on, say SVN repos.

Commit Date  
2016-06-23 16:45:22 Tree
[97fa76] by Rohan Verma Rohan Verma

[#8090] Display merge requests button in sidebar even if there are none for all forkable repos

 2016-06-20 08:01:32 Tree

Discussion

  • Dave Brondsema

    Dave Brondsema - 2016-06-21

    This looks like the wrong commit for the merge request. Is there a different branch maybe?

     

    • Rohan Verma - 2016-06-21

      Oops!

      Have fixed that!

       

  • Rohan Verma - 2016-06-21
    • Source branch: rhnvrm/discussion/change-default-pagination-behavior --> rhnvrm/8090
     

  • Dave Brondsema

    Dave Brondsema - 2016-06-22

    There's an extra space after == in self.forkable == True. Better yet, you can drop the == True altogether and make it cleaner.

     

  • Rohan Verma - 2016-06-23

    Updated!

     

    Last edit: Rohan Verma 2016-06-23

  • Dave Brondsema

    Dave Brondsema - 2016-06-23
    • Status: open --> merged
     

Log in to post a comment.