Functionally working well. Would be nice however to refactor the markup for the modal dialog out into a jinja macro however, so that chunk of code isn't duplicated in two places.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Functionally working well. Would be nice however to refactor the markup for the modal dialog out into a jinja macro however, so that chunk of code isn't duplicated in two places.
Or you mean duplication of this portion
I will do refactoring and push an update. Thanks
Hi. Kenton
Refactored in to separate file since
theme_macros
has only theme related stuff.Last edit: Shalitha Suranga 2018-10-24
Any update regarding this merge request..?
Hi Shalitha,
Refactor looks good, this is now merged!
Thanks Kenton 👍