Git Merge Request #329: Adding high res icon support for user card (merged)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Shalitha Suranga wants to merge 1 commit from /u/shalithasuranga/allura/ to master, 2019-07-11

Fixes [#8304]

Hi.. I think we can reuse the gravatar jinja macro here. WDYT?

Commit Date  
[6006fb] (gsoc19-oth1) by Shalitha Suranga Shalitha Suranga

[#8304] Use higher resolution for user card avatar icon

 2019-06-19 16:51:53 Tree

Discussion

  • Dave Brondsema

    Dave Brondsema - 2019-06-19

    Yes good find for the jinja macro. And it actually automatically emits a srcset attribute with 1.5x and 2x rules, so you only need to call it with the actual width 64. Then it'll emit url references for 96px and 128px in the srcset.

    The last thing to do, to make those work, is to update the project_icon_sizes setting in the .ini file to also include 128 since it doesn't yet.

    You should be able to test this, even if you don't have a hi-dpi (retina) screen or mobile device, by zooming your browser up to 150% and 200% and watch what image is requested.

     
    👍
    1

  • Shalitha Suranga - 2019-06-21

    Hi.. Dave

    I am trying to push my changes to this MR. But blocked with following errors with git push

    ....
....
Total 9 (delta 7), reused 0 (delta 0)
remote: fatal: not a git repository: '.'
error: remote unpack failed: unpack-objects abnormal exit
error: RPC failed; curl 56 GnuTLS recv error (-110): The TLS connection was non-properly terminated.
Everything up-to-date

    Is there an issue in remote ?

    Thanks

     

  • Dave Brondsema

    Dave Brondsema - 2019-06-21

    Hm, yea i get a similar error pushing to my fork too. I did update the server a bit recently when blocking a bot. Not sure exactly what is wrong yet.

    In the mean time, since you are a project committer, you can push directly to the main "origin" remote https://gitbox.apache.org/repos/asf/allura.git/ instead of to your fork. That's what I do actually a lot. Our pattern of naming branches is to use your initials and ticket number (like ss/8304) so that branches on that remote stay very organized.

    With that approach, merge requests aren't possible, but that is ok you can just mention on a ticket when something is ready for review.

     
    👍
    1

    • Shalitha Suranga - 2019-06-21

      Hi.. I've pushed commits to ss/8304. Until we fix the existing issue we can go with this way

      Thanks

       

  • Dave Brondsema

    Dave Brondsema - 2019-06-21
    • Status: open --> merged
     

  • Dave Brondsema

    Dave Brondsema - 2019-07-11

    @shalithasuranga Pushing to a fork should work now. Problem was in [#8317] due to an earlier update of a Dockfile to use a newer ubuntu. That fix is applied to this allura instance now.

    Feel free to use the ss/1234 branch approach too though, either is fine.

     

    Related

    Tickets: #8317

Log in to post a comment.