Apache Allura™

Thanks for this contribution! I'll be looking at it soon.

We're you previously seeing weird behavior with it on mobile? Does this fix it?

My colleague confirms its a lot better on Android now :) So that'll take care of [#8260] I'd had been thinking about doing this upgrade very soon anyway because of the Android problems, so its great you've done it and are contributing it. I did find some changes because of the upgrade, I've listed them below. If you're able to take a look at them great. Otherwise I can help too, since I was thinking about this anyway.

I see you made a few changes in easymde.min.css like added float:none and i.fa{float:none}.editor-toolbar. Those would be best in a separate css file like markitup_sf.css and keep the easymde file as the original. Then if easymde is upgraded in the future, we don't have to worry about your changes getting lost.

The editing box is taller now. Allura sets min-height: 60px; in a few places in markitup_sf.css but those aren't working. It looks like EasyMDE has a minHeight setting which maybe is the better way to set it, and remove the min-height styles?

The last 3 buttons are no longer aligned all the way to the right. I see in our CSS file a /* move these buttons to the right, they are a different type of button */ section to do that. I think all the fa-* selectors need to be updated. (Also some in the middle of the file?)

I see there's more spellcheck options now, so It seems we can set inputStyle: 'contenteditable', and the browser's own spell checker will work now, and will fix [#7954]

LICENSE and Allura/LICENSE should be updated for EasyMDE instead of SimpleMDE

If I type @ to trigger username autocomplete, it doesn't work. The console says cm.showHint is not a function The existing code for this is in show-hint.js/.css (which probably should be updated to latest but that doesn't fix it). And our hook into that is CodeMirror.showHint(...

I think related to that problem, codemirror.js wasn't needed as its own file in the past. It was bundled within SimpleMDE. I think that's probably still bundled in EasyMDE (it need its to work at all). But it's no longer exposed as a top-level CodeMirror variable like our code needs. You probably added the codemirror.js file to fix an error about CodeMirror variable not defined, which helps a bit, but then its not the same instance of CodeMirror that is used within EasyMDE which makes showHint error. I see there is an open issue https://github.com/Ionaru/easy-markdown-editor/issues/167 about including addons and https://github.com/Ionaru/easy-markdown-editor/pull/76 for exposing CodeMirror which I think might be what we want, but isn't merged.

Thanks again, and like I said I'm quite interested in this so if you'd like me to tackle any parts (especially the last stuff about showHint/packaging) that'd be ok.

Thanks again for your contribution. I made a few more tweaks and customizations, and for the EasyMDE/CodeMirror packaging opened https://github.com/Ionaru/easy-markdown-editor/pull/263 and currently we have a custom build with that little tweak, hopefully it'll get merged into their next release.