Apache Allura™

Forge software for hosting software projects

Brought to you by: alexluberg, brondsem, deshani, dill0wn, and 10 others

Git Merge Request #377: Commit package-lock.json and convert to using `npm ci` (merged)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Dillon Walls wants to merge 1 commit from /u/dill0wn/allura/ to master, 2021-10-27

I noticed that package-lock.json is not versioned. More recent npm convention seems to recommend committing that file much like a hashed requirements.txt so that each install uses the same pinned package revisions across installs.

I also updated all references to npm install with npm ci, and the build/setup seemed to work fine in docker.

Commit	Date
[5f2446] (dw/npm-ci) by Dillon Walls switch from npm install -> npm ci	2021-10-26 13:21:32	Tree

Discussion

Dave Brondsema - 2021-10-27

Status: open --> merged
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Apache Allura™

Forge software for hosting software projects

Branches

Tags

Git Merge Request #377: Commit package-lock.json and convert to using `npm ci` (merged)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Discussion