Apache Allura™

Forge software for hosting software projects

Brought to you by: alexluberg, brondsem, ccruz, deshani, and 11 others

Git Merge Request #133: [#8090] Show merge requests in sidebar, even if there are none for forkable repos (merged)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Original repository by Rohan Verma is deleted

I added a check for the repo to be forkable because the Merge Requests button should not be visible on, say SVN repos.

Discussion

Dave Brondsema - 2016-06-21

This looks like the wrong commit for the merge request. Is there a different branch maybe?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Rohan Verma - 2016-06-21
  
  Oops!
  
  Have fixed that!
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Rohan Verma - 2016-06-21

Source branch: rhnvrm/discussion/change-default-pagination-behavior --> rhnvrm/8090
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2016-06-22

There's an extra space after == in self.forkable == True. Better yet, you can drop the == True altogether and make it cleaner.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Rohan Verma - 2016-06-23

Updated!

Last edit: Rohan Verma 2016-06-23

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2016-06-23

Status: open --> merged
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.