Git Merge Request #252: [#1699] Fix incoming email for wiki pages with space in the title, Adds test functionality for handle_message method (merged)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Deshani wants to merge 3 commits from /u/deshani/allura/ to master, 2018-05-09

[#1699] Fix incoming email for wiki pages with space in the title. Spaces in the title are replaced with underscore. Adds test functionality for handle_message method, which is responsible for handling inbound emais for wiki.

Commit Date  
[136421] by deshanigtk deshanigtk

[#1699] Remove redundant parameter from find_page method

 2018-05-09 02:30:44 Tree
[036daf] by deshanigtk deshanigtk

Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/allura

 2018-05-09 02:28:58 Tree
[6b4322] by deshanigtk deshanigtk

[#1699] Fix incoming email for wiki pages with space in the title, Adds test functionality for handle_message method

 2018-05-04 19:38:13 Tree

Discussion

  • Dave Brondsema

    Dave Brondsema - 2018-05-08

    Hi Deshani,

    I see that find_page is modelled after upsert. It doesn't use the version parameter, so it could be simplified quite a bit, removing the else: portion entirely.

    Otherwise this looks great. Nice job getting a good test in place too!

     

  • Deshani

    Deshani - 2018-05-09

    Hi Dave,

    Thanks for the feedback. I've modified the method accordingly.

     

  • Dave Brondsema

    Dave Brondsema - 2018-05-09
    • Status: open --> merged
     

Log in to post a comment.