Apache Allura™

Forge software for hosting software projects

Brought to you by: alexluberg, brondsem, ccruz, deshani, and 11 others

Git Merge Request #55: Ticket #7929 (rejected)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Pranav Sharma wants to merge 0 commits from /u/pranav/allura/ to master, 2015-12-13

Voting is enabled by default. Nosetests checked.

Determining commits...

Discussion

Dave Brondsema - 2015-12-07

Can you update the commit message to [#7929] instead of [7929]? Then it'll automatically link to the ticket in most places :)

In the test_vote method, you can remove the few lines for "enable voting" since it will be already enabled now.

Besides that, this is looking good, everything is working right when I test it manually.

Related

Tickets: ~~#7929~~

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Pranav Sharma - 2015-12-10
  
  https://forge-allura.apache.org/u/pranav/allura/ci/d0ab45952ddbe96ce9bdaaa9cf7d1a21a6841a09/
  
  Renamed the commit message.
  
  Last edit: Pranav Sharma 2015-12-10
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2015-12-10

Nice. How about this part: In the test_vote method, you can remove the few lines for "enable voting" since it will be already enabled now.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Pranav Sharma - 2015-12-13

Status: open --> rejected
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.