Apache Allura™

Forge software for hosting software projects

Brought to you by: alexluberg, brondsem, deshani, dill0wn, and 10 others

Git Merge Request #104: [#4849] Added print media to CSS for making it printer friendly (merged)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Rohan Verma wants to merge 5 commits from /u/rhnvrm/allura/ to master, 2016-04-06

Commit	Date
[9ca27e] (feature-print) by rhnvrm Removed box shadow from buttons in print media	2016-03-24 19:02:56	Tree
[43bd4d] by rhnvrm [#4849] Added print media to CSS for making printer friendly	2016-03-09 19:46:57	Tree
[5d9ed0] by rhnvrm Merge remote-tracking branch 'origin/master'	2016-03-09 20:24:01	Tree
[7dd4bf] by rhnvrm Merge branch 'master' of https://forge-allura.apache.org/git/u/rhnvrm/allura	2016-03-08 18:05:59	Tree
[c0eab9] by rhnvrm Add confirmation dialog to award/awardgrant delete as reported in #7682	2016-03-08 18:04:08	Tree

Discussion

Heith Seewald - 2016-03-11

Looking overall much cleaner.

I did notice that different browsers looked completely different though. And firefox didn’t show much of anything.

Any thoughts on this?

chrome.pdf

firefox.pdf

safari.pdf

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Rohan Verma - 2016-03-12

This error persists even without the @media css in firefox. I am unable to find a fix for this right now. Also print to file feature of firefox seems to be bugged even for github.

chrome_with_media.pdf

chrome_without_media.pdf

firefox_with_media.pdf

firefox_without_media.pdf

git.pdf

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Heith Seewald - 2016-03-24

You're right -- firefox does seem to have some issues.

As for the others -- I think we should remove (or style) the “buttons” that have black backgrounds. (for example a.btn) It would look better and save some ink :)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Rohan Verma - 2016-03-24

Agreed, will edit this.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Rohan Verma - 2016-03-24

I have updated this

Last edit: Rohan Verma 2016-03-24

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Heith Seewald - 2016-04-06

Nailed it. Nice work, Rohan.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Heith Seewald - 2016-04-06

Status: open --> merged
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.