wants to merge 4 commits
Please review and suggest further modifications.
Partially working method with setting cookie via js
Added cookie when visiting from tracker
Changed carets to font-awesome so that they are consistent in other browsers
Added nav feature to goto next and prev tickets
This works ok for going through every ticket, but the feature request is to go through the current search results. I think that would be much more useful too. But it would require somehow keeping track of what the "current" result list is.
Also, relatively minor, but in Chrome the arrow characters have different heights, not sure why.
I think I misinterpreted the requirement.
Bugzilla implents this using a cookie called BUGLIST set to store the results of the search. Should I use this approach?
Yep that would work. maximizeView is a setting that uses a cookie, as an example. Another option is to use the existing session cookie instead of a new cookie. diformat is a setting that is an example like that. Downside there is that it can only be used server-side, not from JS.
Update on progress on this merge request.
I have been able to set the cookies and the navigation seems to work properly but only for a few cases.
1. what do you mean by the main tracker?
3. ticket_num:(12 32 41 45) should work. You can also put OR between them, but that is the simplest form. Using the URL sounds like a good option too, so that users can get to their original search criteria.
ticket_num:(12 32 41 45)
Do we have any risks of hitting a max cookie size? E.g. if a search has thousands of results.
https://forge-allura.apache.org/p/allura/tickets/ is setting the cookie but https://forge-allura.apache.org/p/allura/tickets/search/?q=abc is not.
Okay, will try using the URL.
ticket_search_results.html is the right place to put it, that should run on all listings of tickets, not sure why it wouldn't be working
localStorage could be an alternative to cookies, but really you have thousands of results you probably aren't going to go through all of them one at a time, so we could just have a hard limit of the number of tickets we put in the cookie
Log in to post a comment.