Git Merge Request #129: [#8048] Better email subjects for merge request updates (rejected)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Rohan Verma wants to merge 3 commits from /u/rhnvrm/allura/ to master, 2017-01-20

Email Subjects:
I have changed it to the merge request summary.
So the first email will have just the summary and the mails in the discussions will have the word "discussions" appended to it.

TODO:

  • Update so that it matches as discussed below.
Commit Date  
[8549f3] (feature-improve-emails) by Rohan Verma Rohan Verma

[#8048] Fix the failing tests due to new metalink parameter

 2016-08-03 09:55:50 Tree
[7a3f4a] by Rohan Verma Rohan Verma

[#8048] Updated the subjects in mails being sent out by MRs

 2016-08-03 09:09:50 Tree
[1ad96a] by Rohan Verma Rohan Verma

[#8048] Changed Subject of updates in merge request

 2016-05-26 21:17:22 Tree

Discussion

  • Rohan Verma - 2016-05-26
    • Summary: #8048 Better email subjects for merge request updates and view meta button in emails --> [#8048] Better email subjects for merge request updates and view meta button in emails
     

    Related

    Tickets: #8048

  • Dave Brondsema

    Dave Brondsema - 2016-06-01

    A few tests fail, they need to be updated to match the code changes. Testing for the new behavior specifically would be nice too.

    The commented-out line can just be removed.

    Should we make the subject match exactly to what the initial email is? 'Merge request: ' + mr.summary. The capitalization and ":" are different. Also there is the word "discussion" added to the end automatically, which doesn't match. I tested a few other tools (blog, wiki, etc) and found that the wiki customizes the email subjects. It uses the email_subject property, maybe you can try that for merge requests?

     

  • Rohan Verma - 2016-08-03

    Now it is like, similar to wiki:

    outmail_1  | Subject: [test:git] New Merge Request: ZXCV
outmail_1  | Subject: [test:git] Merge Request #2 ZXCV discussion
outmail_1  | Subject: [test:git] Re: Merge Request #2 ZXCV discussion

    Also fixed the tests.

     

    • Dave Brondsema

      Dave Brondsema - 2016-08-05

      Hrm, I was thinking the subjects should be all exactly the same, not different. That will help gmail put it into a single thread. Unfortunately other mail clients like Thunderbird won't put it into a thread since they don't have the correct In-Reply-To: and References: header values. To set those properly, I believe we can use the message_id param (see ticket.py for an example of how it is set for tickets)

       

  • Rohan Verma - 2016-08-11

    • Summary: [#8048] Better email subjects for merge request updates and view meta button in emails --> [#8048] Better email subjects for merge request updates

    • Description:

    Diff:

    --- old
+++ new
@@ -1,7 +1,7 @@
-1. Email Subjects:
+Email Subjects:
 I have changed it to the merge request summary.
 So the first email will have just the summary and the mails in the discussions will have the word "discussions" appended to it.

-2. View Action Button:
-I have verified it on `outmail` and the meta tags are being embedded correctly but I am not sure if it will appear correctly in email. Also have checked it using https://www.google.com/webmasters/markup-tester/u/0/ but before using it in production, we need to register with google here: https://developers.google.com/gmail/markup/registering-with-google
-This will need to be tested and then registered on the Allura and Sourceforge production servers.
+TODO:
+
+- Update so that it matches as discussed below.
     

    Related

    Tickets: #8048

  • Dave Brondsema

    Dave Brondsema - 2016-12-20

    Hi,

    Is this something you think you want to wrap up? I forget exactly where we left it, but I think we were getting close. Or do you mind if I work on finishing it up?

     

    • Rohan Verma - 2017-01-19

      Hey,

      Sorry for the late response. Even I have forgot where we left it. Will look into this again tonight and let you know ASAP.

       

      • Rohan Verma - 2017-01-20

        I just went through the changes I had made, I don't think I could think of any way to solve this further using the approach that I had used. I'm closing the MR, you can take a look at the branch https://forge-allura.apache.org/u/rhnvrm/allura/ci/feature-improve-emails/tree/ if that helps.

        Thanks

         

  • Rohan Verma - 2017-01-20
    • Status: open --> rejected
     

  • Dave Brondsema

    Dave Brondsema - 2017-01-20

    Ok, no problem. Thanks. I will probably take a look at it at some point, but I haven't had time lately either :)

     

Log in to post a comment.