wants to merge 3 commits
Before applying, should create an empty meta post.
After applying, should not create new meta post.
[#8104] fixed test failiure in test_move_ticket_email_notifications
[#8104] bug squashed which was found in test_move_ticket_email_notifications
[#8104] Skip creating metapost if list of changes is empty
Test failure in test_move_ticket_email_notifications. It would be good to run the test suites before submitting a merge request.
I had ran the tests but it gave an E instead of an F so I ignored it after looking at [#5691].
Looking into it further now, I still am not able to understand why this is happening
I think what's happening in the test is after it moves the tickets, then in line 2242 and below, it's using the edit form for the ticket, and only adds a comment and doesn't make a change to any field. Then the comment is posted, but no notification goes out. Testing that myself I see the same thing happen, so I think the test caught a bug in the change :)
Thanks for explaining. Took some time to understand and think about how to solve it. Have updated the commits.
Unfortunately, the test is still failing :(
Log in to post a comment.