Git Merge Request #15: [#5467] Made "Create ticket" visible to users without permission. (merged)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Heith Seewald wants to merge 0 commits from /u/heiths/hsallura/ to master, 2015-02-20

Determining commits...

Discussion

  • Dave Brondsema

    Dave Brondsema - 2015-02-18

    The sidebar-disabled class and behavior is good. (Although we will need the css copied into the sftheme scss file too)

    For the title text, we shouldn't put tracker-specific title text right in sidebar_menu.html. In general the core Allura package shouldn't have any special knowledge of individual tickets. I'd recommend expanding SitemapEntry to support something like a sidebar_html_attrs field which would be a dict that the template loops through. And then you can pass the title text in through that.

     

  • Heith Seewald - 2015-02-19

    Great points. I'll add support for extra_html_attrs so it can be used for extending anywhere we use SitemapEntry.

     

  • Dave Brondsema

    Dave Brondsema - 2015-02-19

    Looks good now, but one test needs to be updated (it fails now): forgetracker.tests.functional.test_root:TestFunctionalController.test_render_index

     

  • Heith Seewald - 2015-02-19

    I updated the test, thanks Dave.

     

  • Dave Brondsema

    Dave Brondsema - 2015-02-20
    • Status: open --> merged
     

Log in to post a comment.