Repo status: analyzing...
Merging...
Merged
Something went wrong. Please, merge manually
Checking if merge is possible...
Something went wrong. Please, merge manually
Heith Seewald
wants to merge
commits
from /u/heiths/hsallura/
to master,
2015-02-20
Determining commits...
The
sidebar-disabledclass and behavior is good. (Although we will need the css copied into the sftheme scss file too)For the title text, we shouldn't put tracker-specific title text right in
sidebar_menu.html. In general the core Allura package shouldn't have any special knowledge of individual tickets. I'd recommend expandingSitemapEntryto support something like asidebar_html_attrsfield which would be a dict that the template loops through. And then you can pass the title text in through that.Great points. I'll add support for extra_html_attrs so it can be used for extending anywhere we use SitemapEntry.
Looks good now, but one test needs to be updated (it fails now):
forgetracker.tests.functional.test_root:TestFunctionalController.test_render_indexI updated the test, thanks Dave.