Git Merge Request #150: Added link on items of owner column to filter by assigned_to in ticket search (merged)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Rohan Verma wants to merge 1 commit from /u/rhnvrm/allura/ to master, 2016-08-05

To Test:
* Make a new ticket and assign it to a user
* Goto ticket listing
* Click on name of user in assigned to columnt

Commit Date  
[b09e48] (rhnvrm/feature/assigned_to) by Rohan Verma Rohan Verma

Added link items of owner column to filter by assigned_to

2016-07-31 11:17:37 Tree

Discussion

  • Dave Brondsema

    Dave Brondsema - 2016-08-01

    This seems fine, no problem with it. I want to think about it a little bit first though, since there are also user-links when viewing a ticket. Both the Owner and Creator are links there and go to to the profile pages (so do user-links other places, like comments). Both types of links (filter and profile) can be useful

     

    Last edit: Dave Brondsema 2016-08-01
    • Rohan Verma - 2016-08-03

      So, if we look at suppose, https://github.com/PolymerElements/polymer-starter-kit/issues

      There when you are on the ticket listing, clicking on a user name filters the list. Otherwise when you open the full ticket the link leads to the user profile.

      Currently I have only done it for assigned to but I think this can be extended for other columns such as Creator and Reviewer as well. Should I add commits for that as well?

       
      • Dave Brondsema

        Dave Brondsema - 2016-08-05

        Sounds good to me

         
  • Dave Brondsema

    Dave Brondsema - 2016-08-05
    • Status: open --> merged
     

Log in to post a comment.