Apache Allura™

Forge software for hosting software projects

Brought to you by: alexluberg, brondsem, deshani, dill0wn, and 10 others

Git Merge Request #22: Ticket #7826 (merged)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Pranav Sharma wants to merge 0 commits from /u/pranav/allura/ to master, 2015-04-24

Fixed the correct email format. If correct email not present, a message is flashed.

Determining commits...

Discussion

Dave Brondsema - 2015-04-14

Nice work so far. I did find one problem: import re is missing from the file so the new re.match line throws an error.

And one way it could be made a bit better would be to add 'error' as a second parameter to the flash() call so that it shows up in red instead of green. If you look through the file you can see some other flash() calls that do that for example.

Can you make those changes and push them? Thanks!

Ideally code changes would have a tests for them too, but this is a very simple change and testing a flash message has a few tricks. But maybe next contribution you make can have a test too :) https://forge-allura.apache.org/docs/development/contributing.html#testing

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Pranav Sharma - 2015-04-24
  
  Fixed!!
  https://forge-allura.apache.org/p/allura/git/merge-requests/24/
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Pranav Sharma - 2015-04-24

Fixed!!
https://forge-allura.apache.org/p/allura/git/merge-requests/24/

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2015-04-24

Status: open --> merged
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.