Looks like a good start. A few things to change are:
the links don't go to the right place. Instead of linking to {{ req.request_number }}/ it needs to be {{ req.url() }} to get a full url that works from the dashboard page
should have a blank line before def my_merge_requests
if querying by creator_id there should be a mongo index for that field so that its not slow on large databases. You can add it to the MergeRequest.__mongometa__.indexes list.
a different option would be to search solr instead of querying mongo. I think this could be done a lot simpler than the ticket solr search works. But doing the mongo query and just adding the index for it is fine.
IMO, sorting by mod_date is probably more useful than by request_number (If you have merge requests on multiple repos, the numbers will be varied)
-Dave
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hi,
Looks like a good start. A few things to change are:
{{ req.request_number }}/
it needs to be{{ req.url() }}
to get a full url that works from the dashboard pagedef my_merge_requests
creator_id
there should be a mongo index for that field so that its not slow on large databases. You can add it to theMergeRequest.__mongometa__.indexes
list.mod_date
is probably more useful than byrequest_number
(If you have merge requests on multiple repos, the numbers will be varied)-Dave
Hi Dave,
Thanks for reviewing. I've updated the merge request with the required changes.
Regards!
Hi,
The sorting is showing the oldest merge requests first, not the newest.
Hi,
I've updated the merge request