Git Merge Request #269: [8219] Personal Dashboard - Test Tickets section (merged)

Repo status: analyzing...

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Deshani wants to merge 0 commits from /u/deshani/allura-personal-dashboard/ to master, 2018-07-22

Commit Date  

Discussion

  • Dave Brondsema

    Dave Brondsema - 2018-07-18

    I'm real curious what change here made it start working? Was it inheriting from TrackerTestController or using test2 project instead of test/sub1?

    I'm always looking for the simplest that code can get... :D Now that you're inheriting from TrackerTestController can the copies _find_new_ticket_form and new_ticket be removed?

     

    • Deshani

      Deshani - 2018-07-21

      Hi Dave,

      I’ve refactored the code. But found out an issue that it only works when ‘assigned_to_s’ AND ‘reported_by_s’ are same as the user. But in dashboard, it checks whether the ‘assigned_to_s’ OR ‘reported_by_s’ is equal to the user. (It works when I test manually) In MockSOLR search method, as far as I understood, it doesn’t support ‘OR’ condition. Can you check that method?

      Regarding the tickets section, I checked when you said it wasn’t running when testing. But, I didn’t get that issue when checked in my machine.

      Regards!

       

      • Dave Brondsema

        Dave Brondsema - 2018-07-22

        Yeah I think you are right. MockSOLR line 156 handles && but I don't see any mention of OR or ||. It would be nice if it could handle it, but its not really the important part of what you are testing here, so I don't think it's needed to add support for that. I can just merge it without the "bar" test.

        I must've had something weird in my local setup that the tickets section wasn't running. Glad its working now for both of us :)

         

  • Dave Brondsema

    Dave Brondsema - 2018-07-22
    • Status: open --> merged
     

Log in to post a comment.