Apache Allura™

Hi, thanks for this! It's pretty nice improvement. As a new feature though, there is some improvements & changes to do:

It would be good to add a test for this specifically.

The allura.tests.test_utils.TestHTMLSanitizer.test_html_sanitizer_form_elements test is failing. You could just update the test to reflect the fact that <input> tags are displayed now. But I think it would be best of only the checkboxes were allowed and other input types were still sanitized. I think you could do this by uncommenting (ns_html, 'input'), again and then in def sanitize_token after it does some very specific checking for iframes, add some specific checking for input tags. I'm thinking if it is an input and type is checkbox then allow it, but don't allow other types (text, radio, submit, etc). And it's just a single tag so that should make the code simpler than the iframe check (you won't have to deal with "EndTag" and tracking anything like _prev_token_was_ok_iframe hopefully)

if(el.text == 'x' or el.text == ' '): doesn't need the parenthesis - that will make it look a little nicer and match PEP8 guidelines. Also I would suggest adding a comment here. So someone later can know that these lines are for checklists to work (otherwise its not very obvious what they are doing).

The markdown help page should be updated to mention this new feature.

Have you looked into making the checkboxes interactive if you have edit permissions? It looks like the markdown-checklist package has some helper JS for it, but would take custom code to handle the ajax and do the update. Don't to do this now, but it would be nice later of course.

Hi... Dave

Thank you for the guidance. Yeah it was easy with sanitize token. I did those changes now..I will push commits by adding unit test for this improvement

Hi.. Dave

I have made these changes and pushed to marge request

• Fix if condition parantheses and placing a comment
• allow only input type checkbox using sanitized token approach
• Create test case for sanitizer allura.tests.test_utils.TestHTMLSanitizer.test_html_sanitizer_checkbox
• Updating List documentation

Please review and advice next steps

Thanks

Looks good, thanks!