Apache Allura™

BMP files aren't very efficient in terms of file size, so I don't think we would want to keep them as bitmap and serve them that way. If we wanted to allow them for uploads, they should be converted to PNG I think.

Yeah usually bitmaps are heavy in size. Better to convert them to png or jpg

Hi.
I pushed few commits .. added jpeg conversion when file format is bmp. png thumb looked somewhat heavy. png or jpg ?

Works well. I think it'll depend on the exact image if PNG or JPG turns out better, but we'll just have to pick one. JPG can be lossy when it compresses, so I would probably prefer PNG. Even if its a bit heavier its still a lot better than BMP :)

This automatically converts bitmaps when they are attached to tickets, comments, etc too. At first I thought that was great, but then I thought of cases where people want to attach a specific file, perhaps as an example or test case for something and they want that exact file to by attached, and not converted.

So how about adding a parameter like convert_bmp=False to save_image() so that each place that uses it can decide if it makes sense to convert bmp files. And then add_screenshot and save_icon could set it to True. Or something along those lines.

Yeah great.. we will go with PNG then. wow I exactly used convert_bmp boolean before and just remove from commit becasue it looked not very useful because we don't want to save pure bmp anywhere.

I will push some commits with above modifications

Hi.. Dave

I made few commits by adding these this as per below

• Convert bmp to png
• Fix random number appending for bmp duplicates
• Added boolean parameter

Hi Shalitha,

Looking good. Just some cleanup/improvement suggestions now:

Instead of re.compile('(.*)\.(.*)') and checking for match groups, os.path.basename or os.path.splitext are much nicer to use. Easier to understand what is happening.

save_thumbnail doesn't check the convert_bmp parameter - although this doesn't seem to cause any problems, and acutally is good, it makes it so if you upload a BMP to a ticket or forum, it makes a thumbnail that is PNG and keeps the original as BMP :) So how about just removing the parameter from the save_thumbnail method theN?

Thanks :D

Hi..

os.path.splitext now used and removed boolean parameter also

Thanks