Git Merge Request #304: Adding emoji support for markdown (merged)
Merging...
Merged
Something went wrong. Please, merge manually
Checking if merge is possible...
Something went wrong. Please, merge manually
Shalitha Suranga wants to merge 12 commits from /u/shalithasuranga/allura/ to master, 2018-10-23
Solves [#6923] and also will provide good support for comments (people nowadays frequently using emoji codes)
| Commit | Date | |
|---|---|---|
| 2018-10-23 17:48:58 | Tree | |
| 2018-10-23 17:29:20 | Tree | |
| 2018-10-23 06:30:58 | Tree | |
| 2018-10-23 06:29:13 | Tree | |
| 2018-10-22 07:08:29 | Tree | |
| 2018-10-22 07:05:06 | Tree | |
| 2018-10-22 07:03:54 | Tree | |
|
[77b90b]
by
Shalitha Suranga
Merge branch 'emojicode' of https://forge-allura.apache.org/git/u/shalithasuranga/allura into emojicode |
2018-10-18 05:37:15 | Tree |
| 2018-10-17 07:13:03 | Tree | |
|
[d90361]
by
Shalitha Suranga
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/allura |
2018-10-17 03:33:29 | Tree |
|
[6de256]
by
Shalitha Suranga
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/allura |
2018-10-15 08:09:07 | Tree |
|
[4f7fba]
by
Shalitha Suranga
,
pushed by
GitHub
Merge pull request #1 from apache/master Taking latest changes |
2018-10-05 04:33:18 | Tree |
Pretty minor feedback but you have these lines twice in test_atomic:
output = g.markdown.convert(':+1:') assert u'<p>\U0001F44D</p>' in outputAre there any tests for markdown_commit? I don't see any, just
TestCommitMessageExtensionwhich tests that extension itself. Could you add a test that usesmarkdown_commit? It can be simple, just to make sure we have some basic test coverage of it.I don't know that we need a test for it, but I wanted to mention that I manually tested emoji codes within tables, links, etc and they all worked fine there too.
Hi.. Thanks for poiting our the duplication. I removed it and added test case for commit message testing. maybe I missed to add
_committhere.