Git Merge Request #317: Improved reactions list by adding interactivity (merged)
Merging...
Merged
Something went wrong. Please, merge manually
Checking if merge is possible...
Something went wrong. Please, merge manually
Shalitha Suranga wants to merge 9 commits from /u/shalithasuranga/allura/ to master, 2019-03-15
Second fix for [#8263]
| Commit | Date | |
|---|---|---|
| 2019-03-15 10:12:30 | Tree | |
| 2019-03-15 03:35:11 | Tree | |
| 2019-03-14 03:56:19 | Tree | |
| 2019-03-11 05:41:49 | Tree | |
| 2019-03-11 02:35:41 | Tree | |
|
[793e91]
by
Shalitha Suranga
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/allura |
2019-01-14 10:14:40 | Tree |
|
[e874b1]
by
Shalitha Suranga
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/allura |
2018-11-27 07:40:28 | Tree |
| 2018-11-27 07:39:58 | Tree | |
|
[4f7fba]
by
Shalitha Suranga
,
pushed by
GitHub
Merge pull request #1 from apache/master Taking latest changes |
2018-10-05 04:33:18 | Tree |
Looking pretty good! I did notice that if you aren't logged in and don't have permission to add a reaction, the hover cursor looks like you can click on it. And you actually can, but the AJAX method goes to an invalid URL that ends up not doing much. Could we avoid all that if the user doesn't have permission?
Hi.. Dave
Thanks for the review 👍. Yes I've added the permission check now. Please check
The CSS class is a good way to handle it, but I think the permission needs to be changed. Not many people will have 'moderate' access. Looks like we just check against
is_anonymouson thereaction-buttonelement, and on thepost_reactionendpoint. So it should match that.Yeah agree. endpoint checks for
is_anonymouspermission. So I changed the permission check now please checkThanks!