#8263 Indicate current reaction of comment

v1.11.0
closed
None
General
nobody
9 hours ago
2018-11-14
No

Currently when user already reacted to a specific comment it is not indicated to the user. There are several ways of doing that. We can highlight already reacted emoji or otherwise we can display a tooltip for reaction stats like Github does.

Your ideas?

Discussion

  • Dave Brondsema

    Dave Brondsema - 2018-11-14

    I think highlighting it with a border could work well, so it looks active/selected. Similar to how the markdown toolbar buttons work. That would imply you could click on it to undo it, so we'd have to do that interaction too if we did it that way.

     
    👍
    1
  • Shalitha Suranga

    Nice idea! 👍 We can do same as above attachment. I will send a MR

     
  • Shalitha Suranga

    • status: open --> in-progress
     
  • Shalitha Suranga

    Hi..

    Indicator for current reaction is added already. Is there any improvement we can do further? your ideas..

     
  • Dave Brondsema

    Dave Brondsema - 2019-01-22

    In https://forge-allura.apache.org/p/allura/git/merge-requests/311/ we discussed making the display of reactions also be interactive, so if you see your reaction is set, you can click it to remove. Or if someone else reacted, you could click on it to add your reaction quickly (without having to go into the reaction submenu).

    But we also said that could make the code more complicated. If there is a way to do it that isn't too complicated, that would be nice. If it is going to be complicated and a lot more code I think it is ok to leave everything as-is.

     
    👍
    1
  • Shalitha Suranga

    Hi.. Dave

    Yes we can try to add that option of course. I am checking this

    Thanks

     
  • Shalitha Suranga

    • status: in-progress --> review
     
  • Dave Brondsema

    Dave Brondsema - 2019-03-18
    • status: review --> closed
    • assigned_to: Shalitha Suranga
     
  • Dave Brondsema

    Dave Brondsema - 9 hours ago
    • Milestone: unreleased --> v1.11.0
     

Log in to post a comment.