Git Merge Request #324: Updated the python-dateutil version to 2.8.0 (rejected)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Abhishek Chaudhary wants to merge 1 commit from /u/abhishek/abhi2allura/ to master, 2020-04-10

Updated the default python-dateutil version to the latest 2.8.0

Commit Date  
[f1c5c6] (dateutil-update) by Abhishekism9450 Abhishekism9450

Upgrade python-dateutil to latest version.

2019-03-26 14:13:38 Tree

Discussion

  • Dave Brondsema

    Dave Brondsema - 2019-03-26

    Thanks for getting this set as a branch with a single relevant commit. However, you still need to run the test suite with the upgraded package installed. I have gotten a test failure due to the upgraded package.

     
  • Abhishek Chaudhary

    Hello Dave, Can you please let me know where the test fails , because when I run the test suite I didn't get any test failure. Every test suite run fine in my environment.
    Are you using python3 or python2.7 as environment ? because I run the test suite in python2.7 and there was no failure.

     

    Last edit: Abhishek Chaudhary 2019-03-27
  • Dave Brondsema

    Dave Brondsema - 2019-03-27

    The test that failed is allura.tests.test_helpers.test_ago but the real issue is that you aren't getting the test failures. What command are you using to run the test suite? And what command to install updated packages? You need to make sure they both are in the same allura virtualenv (within docker if using docker).

     
  • Abhishek Chaudhary

    I am using docker. For running test suite "docker-compose run web ./run_tests" & for updating packages "docker-compose run web pip install -r requirements.txt " .

    I have an issue about updating Ubuntu to 18.04 , it is not totally supported by docker.
    After using "docker-compose build" , It raises issues in when I try "docker-compose run web scripts/init-docker-dev.sh" and in other docker commands. Please check it once.

     
  • Dave Brondsema

    Dave Brondsema - 2019-03-28

    Ok, those commands are right. I ran them and the package was installed, and the test failure happens as it should.

    So something else must be going wrong. Maybe your change to requirements.txt isn't automatically shared into the docker container? Or something else? I don't know. But you can check to see what is installed with docker-compose run web pip freeze | grep python-dateutil and see what version is installed.

    I haven't had any problems with Ubuntu 18.04 in docker. Are you doing a fresh start with all your docker images and containers removed? That might be necessary. Otherwise, what is the error? Maybe start a new email thread about that.

     
  • Abhishek Chaudhary

    When I try to fresh build the code and install python and JS packages , there is the error.
    There is some files which is not properly imported. I raised the thread.

     
  • Dave Brondsema

    Dave Brondsema - 2020-04-10
    • Status: open --> rejected
     

Log in to post a comment.