Git Merge Request #332: Make memorable.js usable on mobile browsers (rejected)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Ingo wants to merge 1 commit from /u/labi/allura/ to master, 2021-03-09

memorable.js always listened to onChange events. From mobile browsers, those events are only thrown when the input field looses focus. This change solely only improves the mobile experience for standard form fields, as SimpleMDE development stalled and doesn't support mobile browsers.

Currently I disable SimpleMDE on mobile devices, so for me this change helps pretty much. Maybe a switch to easyMDE might help. I'll investigate into that.

Commit Date  
[50be47] (HEAD, master) by ingo <>

Make memorable.js usable on mobile browsers.
- switched to onInput event instead of onChanged.
- also switched SimpleMDE, though it's not usable on mobile browsers, yet.

 2020-01-16 20:09:05 Tree

Discussion

  • Dave Brondsema

    Dave Brondsema - 2020-01-23

    Hi,

    With SimpleMDE textareas, the 'input' is not firing at all it seems. So InputMDE I guess should stay as 'change'?

    And I agree improving mobile usability of the rich text editor would be great, there definitely are some issues currently. I looked at forks a while back, looking again now it does seem that EasyMDE probably is a good choice.

    -Dave

     

  • Dave Brondsema

    Dave Brondsema - 2020-02-25

    Hey @labi any further thoughts about this? Should we just change the InputBasic event only?

     

  • Ingo - 2021-03-09
    • Status: open --> rejected
     

Log in to post a comment.