Git Merge Request #334: Importer for allura's own export format (merged)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Fahri wants to merge 50 commits from /u/fahri/allurafork/ to master, 2020-04-13

This is a importer for allura's own export format. Ticket: #7935

Commit Date  
[913020] (HEADmaster) by Korkmatik Korkmatik

Fixed comparisons with None

2020-04-10 22:37:01 Tree
[214cc0] by Korkmatik Korkmatik

Ran python-modernize

2020-04-10 22:16:47 Tree
[894863] by Korkmatik Korkmatik

Deleted two newlines at the end of the file

2020-04-10 22:06:51 Tree
[099868] by Korkmatik Korkmatik

Fixed wrong comparisons with None

2020-04-10 22:04:40 Tree
[13c9f2] by Fahri Fahri

Extracted load json method

2020-04-10 14:02:25 Tree
[9e08df] by Fahri Fahri

Fixed tabs so alluratest.test_syntax.test_no_tabs will pass

2020-04-10 13:31:24 Tree
[82b05d] by Fahri Fahri

Refactored get_user and annotate method into AlluraImporter class

2020-04-10 13:11:10 Tree
[03e11e] by Fahri Fahri

Added license header

2020-04-10 13:01:26 Tree
[94b939] by Fahri Fahri

Changed comparison with None

2020-04-10 12:58:14 Tree
[c700b4] by Fahri Korkmaz Fahri Korkmaz

Formatted code so it matches pep8 code style guidelines

2020-03-13 23:50:01 Tree
[845dff] by Fahri Korkmaz Fahri Korkmaz

Removed unncecessary code

2020-03-06 17:42:34 Tree
[13c1c4] by Fahri Korkmaz Fahri Korkmaz

Removed commented code

2020-03-06 17:41:42 Tree
[030ba1] by Fahri Korkmaz Fahri Korkmaz

Removed debug code

2020-03-05 16:52:06 Tree
[bf701b] by Fahri Korkmaz Fahri Korkmaz

Fixed wrong test

2020-03-05 16:11:45 Tree
[9aa40e] by Fahri Korkmaz Fahri Korkmaz

Added tests for nested posts

2020-03-05 16:09:42 Tree
[bf5c24] by Fahri Korkmaz Fahri Korkmaz

Added license comment

2020-03-05 15:20:59 Tree
[3cf0fc] by Fahri Korkmaz Fahri Korkmaz

Updated creation of nested posts

2020-03-05 15:13:23 Tree
[7992a1] by Fahri Korkmaz Fahri Korkmaz

Created tests for the controller

2020-03-05 13:28:54 Tree
[817e52] by Fahri Korkmaz Fahri Korkmaz

Removed some debug code from create method in the controller

2020-03-05 13:28:13 Tree
[67a4c4] by Fahri Korkmaz Fahri Korkmaz

Added support for nested posts

2020-03-05 09:52:53 Tree
[9e3844] by Fahri Korkmaz Fahri Korkmaz

Created test_index

2020-03-04 18:14:27 Tree
[309f62] by Fahri Korkmaz Fahri Korkmaz

Added unicode test to test annotate_text() method

2020-03-04 18:03:03 Tree
[433158] by Fahri Korkmaz Fahri Korkmaz

Added test for missing keys

2020-03-04 17:54:24 Tree
[4ec13c] by Fahri Korkmaz Fahri Korkmaz

Added test for add_posts with attachments

2020-03-04 17:42:22 Tree
[5d3dac] by Fahri Korkmaz Fahri Korkmaz

Created tests for add_posts with last_edited key

2020-03-04 17:05:10 Tree
[55dd2f] by Fahri Korkmaz Fahri Korkmaz

Added test for add_posts with unicode characters

2020-03-04 16:53:51 Tree
[46099e] by Fahri Korkmaz Fahri Korkmaz

Added test for add_posts with many posts

2020-03-04 16:38:45 Tree
[886d8b] by Fahri Korkmaz Fahri Korkmaz

Added test for add_posts

2020-03-04 16:29:31 Tree
[aebb0a] by Fahri Korkmaz Fahri Korkmaz

Removed assignment of slug to posts

2020-03-04 16:28:45 Tree
[0f0ab3] by Fahri Korkmaz Fahri Korkmaz

Changed to match unit tests

2020-03-04 15:56:44 Tree
[3c9b36] by Fahri Korkmaz Fahri Korkmaz

Added tests for import_tool method

2020-03-04 15:54:26 Tree
[911441] by Fahri Korkmaz Fahri Korkmaz

Added test for unicode characters

2020-03-04 12:02:10 Tree
[f5ca44] by Fahri Korkmaz Fahri Korkmaz

Created test for creating a general discussion

2020-03-04 09:38:54 Tree
[5e8193] by Fahri Korkmaz Fahri Korkmaz

Added tests for discussion importer

2020-03-02 11:32:48 Tree
[20bb19] by Fahri Korkmaz Fahri Korkmaz

Improved error handling of annotate method

2020-03-02 11:32:18 Tree
[f0833e] by Fahri Korkmaz Fahri Korkmaz

Changed method name to fit naming convention

2020-03-02 11:01:50 Tree
[4af4ba] by Fahri Korkmaz Fahri Korkmaz

Refactored annotate and get_user method

2020-02-28 18:19:28 Tree
[3e3c27] by Fahri Korkmaz Fahri Korkmaz

Refactored annotate method

2020-02-28 18:00:01 Tree
[f8168d] by Fahri Korkmaz Fahri Korkmaz

Added support for anonymous users

2020-02-28 14:44:03 Tree
[6f6385] by Fahri Korkmaz Fahri Korkmaz

Added unicode support to filenames

2020-02-28 14:40:01 Tree
[8340a5] by Fahri Korkmaz Fahri Korkmaz

Clean up work

2020-02-28 10:24:56 Tree
[b625e4] by Fahri Korkmaz Fahri Korkmaz

Fixed bug where forums and threads are related to a wrong app

2020-02-27 14:10:18 Tree
[3f847e] by Fahri Korkmaz Fahri Korkmaz

Cleaned up

2020-02-27 11:37:35 Tree
[10478a] by Fahri Korkmaz Fahri Korkmaz

Added missing attributes

2020-01-30 13:33:44 Tree
[063507] by Korkmatik Korkmatik

No general discussion will be created by default after the import

2020-01-18 11:35:51 Tree
[625709] by Korkmatik Korkmatik

Fixed errors

2020-01-18 11:04:24 Tree
[fa0a50] by Korkmatik Korkmatik

Made minor changes

2020-01-17 22:49:02 Tree
[ff8447] by Korkmatik Korkmatik

Updated the import_tool method

2019-12-22 14:22:01 Tree
[99ad7a] by Korkmatik Korkmatik

added annotate method

2019-12-21 23:51:37 Tree
[e1004d] by Korkmatik Korkmatik

Created forum importer for allura's own export format

2019-12-21 21:05:33 Tree

Discussion

  • Dave Brondsema

    Dave Brondsema - 2020-04-09

    Looking quite good! And quite a lot of tests. Here's a few bits of feedback:

    • the AlluraImporter class looks like a good idea as a base class to share some logic, I see the methods match some that ForgeTrackerImporter has. To actually share it, can ForgeTrackerImporter extend AlluraImporter and remove the methods from ForgeTrackerImporter?
    • == None is better as is None, and != None as is not None
    • ForgeImporters/forgeimporters/forge/alluraImporter.py and ForgeImporters/forgeimporters/forge/templates/discussion/index.html should have a license header at the beginning of the file
     
    • Fahri

      Fahri - 2020-04-10

      Hi Dave,

      I've reworked the importer.

       
  • Dave Brondsema

    Dave Brondsema - 2020-04-10

    Thanks I see you made some other good fixes too. The only issue I see now is some miscommunication about checking for None. I meant == None would better written as is None, and you changed them all the other way.

    There are also some minor tweaks for python3 readiness that would be good. I can do that part when I merge it, or if you want to try it you can run pip install modernize and then python-modernize -n -w ForgeImporters will make the changes automatically and you can commit it.

     

    Last edit: Dave Brondsema 2020-04-10
    • Fahri

      Fahri - 2020-04-10

      Oh, that was a mistake on my part. I haven't read your comment that carefully ...
      But I've fixed the problem and I have also run the python-modernize module.

       
  • Dave Brondsema

    Dave Brondsema - 2020-04-13
    • Status: open --> merged
     
  • Dave Brondsema

    Dave Brondsema - 2020-04-13

    Thanks! Closing [#7935] too

     

    Related

    Tickets: #7935


Log in to post a comment.