Apache Allura™

Forge software for hosting software projects

Brought to you by: alexluberg, brondsem, deshani, dill0wn, and 10 others

Git Merge Request #34: Added a notification after deleting a wiki page (merged)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

LXj wants to merge 2 commits from /u/lxj/allura/ to master, 2015-09-23

Commit	Date
[3334bd] (lxj/42cc_7871) by Aleksey 'LXj' Alekseyev [#7871] ticket:852 Added a test for sending notification on wiki page deletion	2015-09-21 12:41:54	Tree
[7619b1] by Aleksey 'LXj' Alekseyev [#7871] ticket:848 Added a notification after deleting a wiki page	2015-08-29 12:09:01	Tree

Discussion

Dave Brondsema - 2015-09-02

How about adding a test for this? There's already a test_page_delete method, and if you need an example of asserting that a notification was created, take a look at ForgeDiscussion/forgediscussion/tests/functional/test_forum.py Its methods test_posting and test_notifications_escaping have examples of querying and checking for notifications.

Also a minor note about code formatting. This commit has two lines that are split into two lines. We don't follow PEP8's 79-char line length limit, so these lines can be combined into a single line and easier to read, I think. Anything up to 100, even 119 chars long can be ok.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

LXj - 2015-09-21

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

LXj - 2015-09-21

Added a test, sorry for the delay

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dave Brondsema - 2015-09-23

Status: open --> merged
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.