Guillermo Cruz wants to merge 2 commits from /u/guillermocruz/allura/ to master, 2021-08-27
Fixed comments links by setting the limit and page values from url params
Commit | Date | |
---|---|---|
[363944]
(thread-url-params)
by
Guillermo Cruz
fixed code that was redefining the variable params. share url includes params only if page is not 0 |
2021-08-27 18:19:16 | Tree |
[2593b5]
by
Guillermo Cruz
page and limit url params are now being included in threaded comments links |
2021-08-18 17:05:51 | Tree |
Nice. Just some minor feedback for improvement
page
is 0 that parameter can be omitted. Same forlimit
. That'll make the URLs a bit simpler and cleanerparams
is defined & redefined which is a little confusing. Maybe don't doset params = request.params
and then dorequest.params.get(..
when needed