Git Merge Request #51: Ticket #8018 (rejected)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Pranav Sharma wants to merge 0 commits from /u/pranav/allura/ to master, 2015-12-02

Nosetest verified, assertion added.

Determining commits...

Discussion

  • Heith Seewald - 2015-11-30

    This is much cleaner!

    There is still an indentation issue at allura/controllers/auth.py:276. The tabs should be spaces. https://www.python.org/dev/peps/pep-0008/#tabs-or-spaces.

    Thanks :)

     

    • Pranav Sharma - 2015-12-01

      I am checking in vimrc, and also checking in gedit, it seems there are spaces only. What I did is I edited my vimrc with the following command - 

      :set expandtab
:set tabstop=4

      What esle could be done?
      Neither it is giving me an error on compiling with -

      python -tt auth.py
       

      Last edit: Pranav Sharma 2015-12-01

  • Dave Brondsema

    Dave Brondsema - 2015-12-01

    There are several settings in the .ini file which control how user registrations and emails go. One situation is if you have auth.require_email_addr = false. Then a user can register without an email address and skip the "pending" status. Then when they do add an email address to their account, and verify it, it still is not marked as primary. Can you make it handle that situation too? Thanks

     

  • Pranav Sharma - 2015-12-02
    • Status: open --> rejected
     

Log in to post a comment.