Git Merge Request #66: [#8032] Default email id's created and confirmed. (rejected)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Pranav Sharma wants to merge 0 commits from /u/pranav/allura/ to master, 2016-01-11

Determining commits...

Discussion

  • Dave Brondsema

    Dave Brondsema - 2016-01-04

    Looking pretty good, but the new email address doesn't end up showing as the Primary address for the user yet.

    I think to do that it has to be stored in the user preferences too, but I don't remember exactly.

     
  • Dave Brondsema

    Dave Brondsema - 2016-01-11

    Unfortunately it looks like this change causes 4 tests to fail. I think you'll have to look into each of them and figure out why having default email addresses cause them to fail, and how to fix them.

    ======================================================================
    ERROR: allura.tests.functional.test_auth.TestAuth.test_login
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/Users/brondsem/sf/allura/env-osx/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
        self.test(*self.arg)
      File "/Users/brondsem/sf/allura/Allura/allura/tests/functional/test_auth.py", line 67, in test_login
        r = self.app.get('/auth/verify_addr', params=dict(a=ea.nonce))
      File "/Users/brondsem/sf/allura/AlluraTest/alluratest/validation.py", line 307, in get
        resp = super(ValidatingTestApp, self).get(*args, **kw)
      File "/Users/brondsem/sf/allura/AlluraTest/alluratest/validation.py", line 256, in get
        self._validate_params(kwargs.get('params'), 'get')
      File "/Users/brondsem/sf/allura/AlluraTest/alluratest/validation.py", line 253, in _validate_params
        (method, k, v, type(v)))
    TypeError: get key a has value None of type <type 'NoneType'>, not str.
    -------------------- >> begin captured stdout << ---------------------
    Running setup_app() from allura.websetup
    
    --------------------- >> end captured stdout << ----------------------
    
    ======================================================================
    FAIL: allura.tests.functional.test_auth.TestAuth.test_user_added_claimed_address_by_other_user_not_confirmed
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/Users/brondsem/sf/allura/env-osx/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
        self.test(*self.arg)
      File "/Users/brondsem/sf/allura/Allura/allura/tests/decorators.py", line 46, in wrapped
        return func(*args, **kw)
      File "/Users/brondsem/sf/allura/env-osx/lib/python2.7/site-packages/mock.py", line 1201, in patched
        return func(*args, **keywargs)
      File "/Users/brondsem/sf/allura/Allura/allura/tests/functional/test_auth.py", line 260, in test_user_added_claimed_address_by_other_user_not_confirmed
        assert len(M.User.query.get(username='test-admin').email_addresses) == addresses_number + 1
    AssertionError:
    -------------------- >> begin captured stdout << ---------------------
    Running setup_app() from allura.websetup
    
    --------------------- >> end captured stdout << ----------------------
    
    ======================================================================
    FAIL: allura.tests.functional.test_auth.TestAuth.test_user_cannot_claim_more_than_max_limit
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/Users/brondsem/sf/allura/env-osx/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
        self.test(*self.arg)
      File "/Users/brondsem/sf/allura/Allura/allura/tests/decorators.py", line 46, in wrapped
        return func(*args, **kw)
      File "/Users/brondsem/sf/allura/env-osx/lib/python2.7/site-packages/mock.py", line 1201, in patched
        return func(*args, **keywargs)
      File "/Users/brondsem/sf/allura/Allura/allura/tests/functional/test_auth.py", line 279, in test_user_cannot_claim_more_than_max_limit
        assert json.loads(self.webflash(r))['status'] == 'ok'
    AssertionError:
    -------------------- >> begin captured stdout << ---------------------
    Running setup_app() from allura.websetup
    
    --------------------- >> end captured stdout << ----------------------
    
    ======================================================================
    FAIL: allura.tests.functional.test_site_admin.TestUserDetails.test_emails
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/Users/brondsem/sf/allura/env-osx/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
        self.test(*self.arg)
      File "/Users/brondsem/sf/allura/Allura/allura/tests/functional/test_site_admin.py", line 682, in test_emails
        extra_environ=dict(username='test-admin'))
      File "/usr/local/Cellar/python/2.7.10_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/contextlib.py", line 24, in __exit__
        self.gen.next()
      File "/Users/brondsem/sf/allura/Allura/allura/tests/decorators.py", line 175, in audits
        message=re.compile(preamble + message))).count(), 'Could not find "%s"' % message
    AssertionError: Could not find "Email address deleted: test2@example.com"
    -------------------- >> begin captured stdout << ---------------------
    Running setup_app() from allura.websetup
    
    --------------------- >> end captured stdout << ----------------------
    
     
  • Dave Brondsema

    Dave Brondsema - 2016-01-11
    • Status: open --> rejected
     

Log in to post a comment.