Unfortunately it looks like this change causes 4 tests to fail. I think you'll have to look into each of them and figure out why having default email addresses cause them to fail, and how to fix them.
======================================================================ERROR:allura.tests.functional.test_auth.TestAuth.test_login----------------------------------------------------------------------Traceback(mostrecentcalllast):File"/Users/brondsem/sf/allura/env-osx/lib/python2.7/site-packages/nose/case.py",line197,inrunTestself.test(*self.arg)File"/Users/brondsem/sf/allura/Allura/allura/tests/functional/test_auth.py",line67,intest_loginr=self.app.get('/auth/verify_addr',params=dict(a=ea.nonce))File"/Users/brondsem/sf/allura/AlluraTest/alluratest/validation.py",line307,ingetresp=super(ValidatingTestApp,self).get(*args,**kw)File"/Users/brondsem/sf/allura/AlluraTest/alluratest/validation.py",line256,ingetself._validate_params(kwargs.get('params'),'get')File"/Users/brondsem/sf/allura/AlluraTest/alluratest/validation.py",line253,in_validate_params(method,k,v,type(v)))TypeError:getkeyahasvalueNoneoftype<type'NoneType'>,notstr.-------------------->>begincapturedstdout<<---------------------Runningsetup_app()fromallura.websetup--------------------->>endcapturedstdout<<----------------------======================================================================FAIL:allura.tests.functional.test_auth.TestAuth.test_user_added_claimed_address_by_other_user_not_confirmed----------------------------------------------------------------------Traceback(mostrecentcalllast):File"/Users/brondsem/sf/allura/env-osx/lib/python2.7/site-packages/nose/case.py",line197,inrunTestself.test(*self.arg)File"/Users/brondsem/sf/allura/Allura/allura/tests/decorators.py",line46,inwrappedreturnfunc(*args,**kw)File"/Users/brondsem/sf/allura/env-osx/lib/python2.7/site-packages/mock.py",line1201,inpatchedreturnfunc(*args,**keywargs)File"/Users/brondsem/sf/allura/Allura/allura/tests/functional/test_auth.py",line260,intest_user_added_claimed_address_by_other_user_not_confirmedassertlen(M.User.query.get(username='test-admin').email_addresses)==addresses_number+1AssertionError:-------------------->>begincapturedstdout<<---------------------Runningsetup_app()fromallura.websetup--------------------->>endcapturedstdout<<----------------------======================================================================FAIL:allura.tests.functional.test_auth.TestAuth.test_user_cannot_claim_more_than_max_limit----------------------------------------------------------------------Traceback(mostrecentcalllast):File"/Users/brondsem/sf/allura/env-osx/lib/python2.7/site-packages/nose/case.py",line197,inrunTestself.test(*self.arg)File"/Users/brondsem/sf/allura/Allura/allura/tests/decorators.py",line46,inwrappedreturnfunc(*args,**kw)File"/Users/brondsem/sf/allura/env-osx/lib/python2.7/site-packages/mock.py",line1201,inpatchedreturnfunc(*args,**keywargs)File"/Users/brondsem/sf/allura/Allura/allura/tests/functional/test_auth.py",line279,intest_user_cannot_claim_more_than_max_limitassertjson.loads(self.webflash(r))['status']=='ok'AssertionError:-------------------->>begincapturedstdout<<---------------------Runningsetup_app()fromallura.websetup--------------------->>endcapturedstdout<<----------------------======================================================================FAIL:allura.tests.functional.test_site_admin.TestUserDetails.test_emails----------------------------------------------------------------------Traceback(mostrecentcalllast):File"/Users/brondsem/sf/allura/env-osx/lib/python2.7/site-packages/nose/case.py",line197,inrunTestself.test(*self.arg)File"/Users/brondsem/sf/allura/Allura/allura/tests/functional/test_site_admin.py",line682,intest_emailsextra_environ=dict(username='test-admin'))File"/usr/local/Cellar/python/2.7.10_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/contextlib.py",line24,in__exit__self.gen.next()File"/Users/brondsem/sf/allura/Allura/allura/tests/decorators.py",line175,inauditsmessage=re.compile(preamble+message))).count(),'Could not find "%s"'%messageAssertionError:Couldnotfind"Email address deleted: test2@example.com"-------------------->>begincapturedstdout<<---------------------Runningsetup_app()fromallura.websetup--------------------->>endcapturedstdout<<----------------------
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Looking pretty good, but the new email address doesn't end up showing as the Primary address for the user yet.
I think to do that it has to be stored in the user preferences too, but I don't remember exactly.
https://forge-allura.apache.org/u/pranav/allura/ci/047d7aec940e1560c3a6738c118355312345a0f5/
Made primary.
Unfortunately it looks like this change causes 4 tests to fail. I think you'll have to look into each of them and figure out why having default email addresses cause them to fail, and how to fix them.