#1379 Duplicate subscriptions to tickets

v1.0.0
closed
Jenny Steele
sf-2 (994)
General
nobody
2015-08-20
2011-01-20
Wayne Davison
No

I noticed that my subscriptions have duplicate entries in them -- for wdavison: https://sourceforge.net/auth/prefs/

For instance, I create a ticket, then comment on the ticket, and the comment produces a duplicate subscription. Comment again, get yet another subscription.

Discussion

  • Rick Copeland - 2011-01-24
    • size: --> 1
     

  • Jenny Steele - 2011-01-25
    • status: open --> in-progress
    • assigned_to: Jenny Steele
     

  • Dave Brondsema

    Dave Brondsema - 2011-01-26
    • status: in-progress --> code-review
    • assigned_to: Jenny Steele --> Dave Brondsema
     

  • Dave Brondsema

    Dave Brondsema - 2011-01-27

    I couldn't duplicate the original issue but the added logic looks right.

    It could be a bit cleaner by putting artifact_already_subscribed lines in the existing "if artifact is None" else-clause, instead of a new block before it.

    Will we need to do clean up? I.e. do duplicate subscriptions send duplicate emails?

     

  • Dave Brondsema

    Dave Brondsema - 2011-01-27
    • status: code-review --> open
    • assigned_to: Dave Brondsema --> Jenny Steele
     

  • Jenny Steele - 2011-01-27

    I moved the logic as you suggested. I think in planning we decided cleanup wouldn't be needed.

     

  • Jenny Steele - 2011-01-27
    • status: open --> code-review
    • assigned_to: Jenny Steele --> Dave Brondsema
     

  • Dave Brondsema

    Dave Brondsema - 2011-01-27
    • status: code-review --> closed
    • assigned_to: Dave Brondsema --> Jenny Steele
     

Log in to post a comment.