#1484 Turn off line numbers when displaying scm diffs

v1.0.0
closed
Dave Brondsema
sf-2 (994)
General
nobody
2015-08-20
2011-02-10
Rick Copeland
No

Discussion

  • Rick Copeland - 2011-02-10
    • Description has changed:

    Diff:

    --- old 
+++ new 
@@ -1,0 +1,1 @@
+Example of a weird formatting issue due to line numbers: https://sourceforge.net/p/pylonsproject/tg2/tg2docs/ci/fb1e2e32a74a5484a7203e11d5517eb786ce42ae/tree/docs/main/Deployment/ModWSGI.rst?diff=ba1920e05a7b49f8b8e913965439bcba3e1b576e
     

  • Dave Brondsema

    Dave Brondsema - 2011-02-10
    • summary: Turn off line numbers when displaying diffs --> Turn off line numbers when displaying scm diffs
    • size: --> 1
     

  • John Hoffman - 2011-02-16
    • status: open --> in-progress
    • assigned_to: John Hoffmann
     

  • Dave Brondsema

    Dave Brondsema - 2011-02-17
    • status: in-progress --> code-review
    • assigned_to: John Hoffmann --> Dave Brondsema
     

  • Dave Brondsema

    Dave Brondsema - 2011-02-17

    I think Rick started looking at this too.

    It works for me. Code-wise, I'd recommend the "formatter = " line to be broken up into 4 lines as a regular if/else. It's a pretty long line.

     

  • Rick Copeland - 2011-02-17

    Also, make sure you don't use h.really_unicode(filename).... | safe - if you need to unescape the  , use h.html.literal('&nbsp')

     

  • John Hoffman - 2011-02-17
    • status: code-review --> closed
     

Log in to post a comment.