#1695 Add a Save button to the top half of the ticket view somewhere

unreleased
in-progress
Pranav Sharma
None
Tracker
Dave Brondsema
2016-03-23
2011-03-14
John Hoffman
No

Editing a ticket to change the status, milestone, or owner and then having to scroll to the bottom of the page to save the changes could be less painful with an additional save button near the top of the form.

Discussion

  • Pranav Sharma - 2016-03-12
    • Reviewer: Dave Brondsema
     

  • Pranav Sharma - 2016-03-12

    @Dave

    One issue is that a test with id =

    forgetracker.tests.functional.test_root.TestFunctionalController.test_new_image_attachment_content

    is failing on the master branch too. I believe its because of the attachment's thumb url which is giving 404 response because it's not created locally. I haven't verified it on the actual remote server though.

    Else, all the tests are passed in this branch -

    https://forge-allura.apache.org/u/pranav/allura/ci/pr/1695/~/tree/

     

  • Pranav Sharma - 2016-03-14

    @Dave, Any updates on this one?

     

    Last edit: Pranav Sharma 2016-03-14

  • Dave Brondsema

    Dave Brondsema - 2016-03-16

    Adding the extra line for the button and cancel link pushes everything down a bit. Could you experiment with displaying it on the same line as the summary? In that dark bar, all the way to the right. Maybe you don't even need a Cancel link?

    The flag variable should be renamed to something more specific. And if flag == True: can be better written just if flag: Nice work figuring out that area of code though. It is "EasyWidgets" which is far from easy. In some new places we don't even use it since its fairly confusing.

    When you're done can you rebase and squash all the commits into one? And put [#1695] at the beginning of the commit message. That helps us link our commits to the ticket and its discussion.

     

  • Dave Brondsema

    Dave Brondsema - 2016-03-16
    • status: open --> in-progress
    • assigned_to: Pranav Sharma
     

    • Pranav Sharma - 2016-03-17

      I have removed the cancel link, and also made the save button placed over the right of title box on the dark bar.
      I have renamed the flag variable, but not sure with the new name. I have verified that all the tests are passing except the one mentioned above in the discussion. And I have rebased the branch and squashed the commits into one single commit.

      please check the branch so that i can make the merge request.

      https://forge-allura.apache.org/u/pranav/allura/ci/pr/1695/~/tree/

       

  • Dave Brondsema

    Dave Brondsema - 2016-03-23

    The button isn't position in the same spot when you go to create a new ticket, since the CSS only gets included on the page for existing tickets. You could instead put the CSS in the ForgeTracker/forgetracker/nf/tickets/css/tracker.css file and then I think it should be included on both types of pages.

    And you don't necessarily need to make a separate merge request since we already have this ticket tracking the issue and our comments about it.

     

Log in to post a comment.