#1742 Core tests should not require all the tools to be installed

unreleased
open
nobody
cleanup (28)
General
nobody
2015-02-05
2011-03-17
Dave Brondsema
No

ForgeTracker, ForgeHg, etc, and even their respective dependencies are required just to run a core test. Only Allura and AlluraTesting should be required, so it's easier for people to develop locally without setting up the scm deps.

  File "/Users/brondsem/sf/forge/AlluraTesting/alluratest/controller.py", line 51, in setup_functional_test
    setup_basic_test(config, app_name)
  File "/Users/brondsem/sf/forge/AlluraTesting/alluratest/controller.py", line 46, in setup_basic_test
    cmd.run([test_file])
  File "/Users/brondsem/sf/forge_env/lib/python2.6/site-packages/paste/script/appinstall.py", line 68, in run
    return super(AbstractInstallCommand, self).run(new_args)
  File "/Users/brondsem/sf/forge_env/lib/python2.6/site-packages/paste/script/command.py", line 218, in run
    result = self.command()
  File "/Users/brondsem/sf/forge_env/lib/python2.6/site-packages/paste/script/appinstall.py", line 456, in command
    self, config_file, section, self.sysconfig_install_vars(installer))
  File "/Users/brondsem/sf/forge_env/lib/python2.6/site-packages/paste/script/appinstall.py", line 598, in setup_config
    mod.setup_app, command, filename, section, vars)
  File "/Users/brondsem/sf/forge_env/lib/python2.6/site-packages/paste/script/appinstall.py", line 612, in _call_setup_app
    func(command, conf, vars)
  File "/Users/brondsem/sf/forge/Allura/allura/websetup/__init__.py", line 19, in setup_app
    bootstrap.bootstrap(command, conf, vars)
  File "/Users/brondsem/sf/forge/Allura/allura/websetup/bootstrap.py", line 65, in bootstrap
    wipe_database()
  File "/Users/brondsem/sf/forge/Allura/allura/websetup/bootstrap.py", line 205, in wipe_database
    flyway.run(['--force', '-u', 'mim:///'+db.name])
  File "/Users/brondsem/sf/forge_env/lib/python2.6/site-packages/paste/script/command.py", line 218, in run
    result = self.command()
  File "/Users/brondsem/sf/forge_env/lib/python2.6/site-packages/flyway/command.py", line 31, in command
    self._load_migrations()
  File "/Users/brondsem/sf/forge_env/lib/python2.6/site-packages/flyway/command.py", line 89, in _load_migrations
    reload(ep.load())
  File "build/bdist.linux-i686/egg/pkg_resources.py", line 1954, in load
    entry = __import__(self.module_name, globals(),globals(), ['__name__'])
  File "/Users/brondsem/sf/forge/Allura/allura/migrations.py", line 15, in <module>
    from forgesvn import model as SVNM
  File "/Users/brondsem/sf/forge/ForgeSVN/forgesvn/model/__init__.py", line 1, in <module>
    from svn import Repository
  File "/Users/brondsem/sf/forge/ForgeSVN/forgesvn/model/svn.py", line 12, in <module>
    import pysvn
ImportError: No module named pysvn

Discussion

  • Dave Brondsema

    Dave Brondsema - 2011-03-17

    Maybe it's as simple as moving the migrations.py imports to go within the classes, instead of top-level

     

  • Dave Brondsema

    Dave Brondsema - 2011-04-27
    • labels: --> cleanup
     

  • Dave Brondsema

    Dave Brondsema - 2011-05-11
    • milestone: limbo --> backlog
     

  • Dave Brondsema

    Dave Brondsema - 2013-08-14

    Only ForgeWiki should really be required (as a default tool for projects)

    Seems like currently ForgeActivity is required, and Tickets, maybe more. Shouldn't be too hard to remove them. Example of tickets:

    allura.tests.functional.test_admin.TestProjectAdmin.test_admin_controller
...
  File "/private/tmp/allura/Allura/allura/ext/admin/templates/project_admin.html", line 77, in block "content"
    <img src="{{ g.theme.app_icon_url('Tickets', 48) }}" alt="">
  File "/private/tmp/allura/Allura/allura/lib/plugin.py", line 847, in app_icon_url
    return g.entry_points['tool'][app].icon_url(size)
  File "/private/tmp/allura/Allura/allura/lib/utils.py", line 390, in __getitem__
    return self.store[self.__keytransform__(key)]
KeyError: u"'tickets'
     

Log in to post a comment.