#1894 source-code browser chokes on unicode filenames when they participate in a URL

v1.0.0
closed
Wolf
sf-2 (994)
SCM
nobody
2015-08-20
2011-04-05
Wolf
No

...for example when you click on a unicode filename listed, it would go to a path that ends with that files name, a unicode string; you get a 500.

Discussion

  • Dave Brondsema

    Dave Brondsema - 2011-04-07
    • component: General --> SCM
    • milestone: limbo --> apr-14
     

  • Dave Brondsema

    Dave Brondsema - 2011-04-07
    • size: --> 2
     

  • Jenny Steele - 2011-04-08
    • status: open --> in-progress
    • assigned_to: Jenny Steele
     

  • Jenny Steele - 2011-04-08

    Fix is on js/1894. The problem was present in Hg and SVN, but Git worked correctly already. To test:

    1) Create an Hg repo.
    2) Add a file with a unicode name.
    3) Click the link in the file browser and make sure it loads.
    4) Repeat for SVN.

    • status: in-progress --> code-review
    • assigned_to: Jenny Steele --> Wolf
     

  • Wolf - 2011-04-11
    • status: code-review --> closed
     

  • Wolf - 2011-04-11

    tested, merged to dev as 9566072

     

Log in to post a comment.