#2022 CompoundError accumulations should have a size limit

unreleased
invalid
nobody
None
General
nobody
2011-06-23
2011-04-27
Dave Brondsema
No

Wherever we accumulate exceptions for a CompoundError (e.g. add_artifacts) it should have a max size, e.g. 50. After that quit the loop and raise the exception.

This is to short circuit problems (e.g. communication with solr) instead of trying it thousands of times.

While we're at it, put it code after "ref = M.ArtifactReference.query.get(_id=ref_id)" to see if it's None. Log and continue.

Discussion

  • Dave Brondsema

    Dave Brondsema - 2011-04-27
    • Description has changed:

    Diff:

    --- old 
+++ new 
@@ -1,3 +1,7 @@
 Wherever we accumulate exceptions for a CompoundError (e.g. add_artifacts) it should have a max size, e.g. 50.  After that quit the loop and raise the exception.

 This is to short circuit problems (e.g. communication with solr) instead of trying it thousands of times.
+
+-----
+
+While we're at it, put it code after "ref = M.ArtifactReference.query.get(_id=ref_id)" to see if it's None.  Log and continue.
     

  • Dave Brondsema

    Dave Brondsema - 2011-04-28
    • status: open --> invalid
     

  • Dave Brondsema

    Dave Brondsema - 2011-04-28

    2nd part done (trivial); first part doesn't have a clean solution and only was a problem once

     

Log in to post a comment.