#2058 ACL fixes

v1.0.0
closed
sf-2 (994)
General
nobody
2015-08-20
2011-05-02
No

[#1909] didn't work so well in prod. Rick force-pushed updates on rc/1909. Test them

Related

Tickets: #1909

Discussion

  • Rick Copeland - 2011-05-02

    Testing to make sure we can insert into the DB

     
  • Dave Brondsema

    Dave Brondsema - 2011-05-02

    Also need to update scripts/create-neighborhood.py. Let's move it to a Command, so we can write a test for it.

     
  • Dave Brondsema

    Dave Brondsema - 2011-05-03

    These shouldn't be all root:

    15:12:17,007 INFO  [update-acls] ... grant nbhd admin to: root
    15:12:17,008 INFO  [update-acls] ... grant nbhd admin to: root
    15:12:17,009 INFO  [update-acls] ... grant nbhd admin to: root
    15:12:17,009 INFO  [update-acls] ... grant nbhd admin to: root
    15:12:17,010 INFO  [update-acls] ... grant nbhd admin to: root
    

    A test for the CreateNeighborhoodCommand would be good.

    The following is needed to prevent 500s on pages that show user icons:

    --- a/Allura/allura/model/auth.py
    +++ b/Allura/allura/model/auth.py
    @@ -300,7 +300,13 @@ def url(self):
    
         def icon_url(self):
             icon_url = None
    -        if self.private_project() and self.private_project().icon:
    +        try:
    +            priv_proj = self.private_project()
    +        except:
    +            log.exception('Error getting private_project()')
    +            priv_proj = None
    +
    +        if priv_proj and priv_proj.icon:
                 icon_url = '/u/'+self.username.replace('_', '-')+'/user_icon'
             elif self.preferences.email_address:
                 icon_url = g.gravatar(self.preferences.email_address, default=None)
    

    I need to retest Nbhd auth after it is fixed.

     
  • Dave Brondsema

    Dave Brondsema - 2011-05-03
    • assigned_to: Dave Brondsema --> Rick Copéland
     
  • Rick Copeland - 2011-05-03
    • assigned_to: Rick Copéland --> Dave Brondsema
     
  • Dave Brondsema

    Dave Brondsema - 2011-05-03
    • status: open --> closed
     

Log in to post a comment.