#2144 ".markdown_content p {margin-bottom: 20px;}" was this really intended?

v1.0.0
closed
Jenny Steele
sf-1 (616)
General
nobody
2015-08-20
2011-05-19
Anonymous
No

Originally created by: wladid

After the producution push yesterday (2011-05-18), I noticed some CSS restrictions.

Especially in lists with paragraphs (wiki pages/homepage).

Paragraphs had already padding-bottom 13px and now additionally margin-bottom 20px
=> 33px of trailing white space on each p!

Need a example?

Related

Tickets: #2166

Discussion

  • Anonymous - 2011-05-19

    Originally by: wladid

    • Description has changed:

    Diff:

    --- old 
+++ new 
@@ -5,4 +5,4 @@
 Paragraphs had already padding-bottom 13px and now additionally margin-bottom 20px
 => 33px of trailing white space on each p!

-[Need a example?](https//sourceforge.net/p/lauge/home/)
+[Need a example?](http://sourceforge.net/p/lauge/home/)
     

    Last edit: Anonymous 2015-02-28

  • Dave Brondsema

    Dave Brondsema - 2011-05-19
    • milestone: limbo --> may-26
     

  • Dave Brondsema

    Dave Brondsema - 2011-05-19
    • size: --> 1
     

  • Kyle Adams - 2011-05-19

    Seems to me the actual problem here is paragraphs within lists.

    When a paragraph existed as a top-level element in markdown content, it used to have no margin whatsoever, leading multiple paragraphs to run together. Consequently the 20px bottom margin is very intentional.

    I think our best approach is to keep the 20px bottom margin but tweak rules as needed to ensure consistent spacing. In this case, I'd add something like:

    .markdown_content li > p { margin-bottom: $grid-gutter-width / 2; } // 10px
     

  • Kyle Adams - 2011-06-07
    • status: open --> in-progress
    • assigned_to: Kyle Adams
     

  • Kyle Adams - 2011-06-07

    sftheme:ka/2144

    To QA, setup a wiki page with the following Markdown:

    * <p>Testing paragraphs within a list.</p>
    <p>This is a second paragraph within the same list item.</p>
    * A second list item.
    * A third list item.

    There should be no padding or margin around the paragraphs, similar to normal list items.

     

  • Kyle Adams - 2011-06-07
    • status: in-progress --> code-review
    • assigned_to: Kyle Adams --> Jenny Steele
     

  • Jenny Steele - 2011-06-07

    The change looks good, but it should also be made in the allura theme css.

     

  • Jenny Steele - 2011-06-07
    • status: code-review --> open
    • assigned_to: Jenny Steele --> Kyle Adams
     

  • Kyle Adams - 2011-06-07
    • status: open --> code-review
    • assigned_to: Kyle Adams --> Jenny Steele
     

  • Kyle Adams - 2011-06-07

    Changes sync'd over to Allura's theme.

     

  • Dave Brondsema

    Dave Brondsema - 2011-06-07
    • status: code-review --> closed
     

Log in to post a comment.