#2699 [Tickets tool] Milestone names accept invalid characters

v1.0.0
closed
Tim Van Steenburgh
Tickets (1) Milestone (1) sf-2 (994)
Tracker
nobody
2015-08-20
2011-08-26
Anonymous
No

Originally created by: cohadar

You need some input checking for milestone names.
I tried to use character plus '+' in my milestone name: v1.0+
and the link for that milestone stopped working.

Related

Tickets: #2714
Tickets: #2894

Discussion

  • Anonymous - 2011-08-26

    Originally by: cohadar

    • summary: Milestone names accept invalid characters --> [Tickets tool] Milestone names accept invalid characters

    • labels: --> Tickets, Milestone

    • component: General --> Tracker
    • milestone: limbo --> mkt-sep-09
     

  • Tim Van Steenburgh - 2011-09-02

    Accept weird chars, but urlencode them in links. Update tests to include milestones with weird characters.

    • size: --> 2
     

  • Mark Ramm - 2011-09-06
    • milestone: forge-sep-16 --> forge-sept-30
     

  • Dave Brondsema

    Dave Brondsema - 2011-09-19

    b5e1d88544396734147ad0ee68badce404c192f5 made some fixes, but I can still get errors when using milestones containing ":" or "/" or "+". Make sure that milestone views work, solr searches work, and ticket create/edit works.

     

  • Tim Van Steenburgh - 2011-09-23
    • status: open --> in-progress
    • assigned_to: Tim Van Steenburgh
     

  • Tim Van Steenburgh - 2011-11-04

    forge:tv/2699

    This was mostly working already. My additions were to:

    1. replace '/' with '-' since we can't deal with forward slashes with our current version of apache
    2. Added quotes around solr searches so that ':' won't break the search.
     

  • Tim Van Steenburgh - 2011-11-04
    • status: in-progress --> code-review
    • assigned_to: Tim Van Steenburgh --> Dave Brondsema
     

  • Dave Brondsema

    Dave Brondsema - 2011-11-07
    • status: code-review --> closed
    • assigned_to: Dave Brondsema --> Tim Van Steenburgh
     

Log in to post a comment.