John Hoffmann: quick question when you have time, for #316, you changed the description from 'track ip addresses' to 'verify that ip addresses are logged', can you elaborate a bit? i dug thru the code and didn't see us capturing them anywhere, though the history seems to indicate we might be doing it, perhaps outside of python? (httpd logs?)
Richard Copeland: let's see -- I changed that in Nov, so I don't exactly recall
John Hoffmann: it was created in April
Richard Copeland: I think the point now is to make sure that the commit() method on versioned artifacts saves the IP in the snapshot object
John Hoffmann: ok, i'll poke at it then
Richard Copeland: thanks
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
John Hoffmann: quick question when you have time, for #316, you changed the description from 'track ip addresses' to 'verify that ip addresses are logged', can you elaborate a bit? i dug thru the code and didn't see us capturing them anywhere, though the history seems to indicate we might be doing it, perhaps outside of python? (httpd logs?)
Richard Copeland: let's see -- I changed that in Nov, so I don't exactly recall
John Hoffmann: it was created in April
Richard Copeland: I think the point now is to make sure that the commit() method on versioned artifacts saves the IP in the snapshot object
John Hoffmann: ok, i'll poke at it then
Richard Copeland: thanks
Rick, can you fix the testing framework so it sets up a dummy request object?
There's also going to be code that runs without a request - all the background reactor processes.
New commit and sent back for review