#3417 Tests should only install the needed tools

v1.0.0
closed
Tim Van Steenburgh
sf-4 (350)
General
nobody
2015-08-20
2011-12-09
Dave Brondsema
No

In bootstrap.py, there is a lot of install_app() calls that run when in test mode, but we don't need to do that for every functional test. Remove them from bootstrap.py and set each tool to install itself (e.g. ForgeWiki would install wiki in the setup of its functional tests). There may be some other implicit tool dependencies (e.g. Allura core tests may assume some exist) so other updates may be necessary. It's ok to add needed tools back for those tests, but it would be best if Allura core tests didn't install any of the scm tools (since their dependencies can be a pain to set up on some systems)

Discussion

  • Dave Brondsema

    Dave Brondsema - 2011-12-16
    • size: --> 4
     

  • John Hoffman - 2011-12-20
    • status: open --> in-progress
    • assigned_to: John Hoffmann ☠
     

  • John Hoffman - 2011-12-22
    • status: in-progress --> open
    • assigned_to: John Hoffmann ☠ --> nobody
     

  • John Hoffman - 2011-12-22

    DO NOT WANT

     

  • Tim Van Steenburgh - 2011-12-29
    • status: open --> in-progress
    • assigned_to: Tim Van Steenburgh
     

  • Tim Van Steenburgh - 2012-01-05

    forge:tv/3417

    QA: Run ./run_tests, make sure all tests pass (they did for me). Code review allura/tests/decorators.py, make sure I didn't do anything dumb.

     

  • Tim Van Steenburgh - 2012-01-05
    • qa: Rick Copeland ☕
     

  • Tim Van Steenburgh - 2012-01-06
    • status: in-progress --> code-review
     

  • Rick Copeland - 2012-01-06
    • status: code-review --> closed
     

  • Rick Copeland - 2012-01-06

    After a minor code adjustment, it looks good. Closing out the ticket now.

     

Log in to post a comment.